Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] add --repack flag to eas build command #2384

Merged
merged 2 commits into from
May 17, 2024

Conversation

szdziedzic
Copy link
Member

Why

Add the --repack flag to the eas build command. This flag is not intended to be user-facing, it's just for us to test the onboarding repack flow

How

Add hidden --repack flag to eas build command. If the flag is used run build as custom with __eas/repack.yml config

Test Plan

test manually

@szdziedzic szdziedzic added the no changelog PR that doesn't require a changelog entry label May 16, 2024
Copy link

github-actions bot commented May 16, 2024

Size Change: +1.41 kB (0%)

Total Size: 51.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.3 MB +1.41 kB (0%)

compressed-size-action

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 53.45%. Comparing base (ca803ee) to head (eb2bde1).

Current head eb2bde1 differs from pull request most recent head e9acfce

Please upload reports for the commit e9acfce to get more accurate results.

Files Patch % Lines
packages/eas-cli/src/build/ios/prepareJob.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2384      +/-   ##
==========================================
- Coverage   53.46%   53.45%   -0.00%     
==========================================
  Files         530      530              
  Lines       19504    19505       +1     
  Branches     3959     3960       +1     
==========================================
  Hits        10425    10425              
- Misses       8327     8328       +1     
  Partials      752      752              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@szdziedzic szdziedzic merged commit 1a17028 into main May 17, 2024
5 checks passed
@szdziedzic szdziedzic deleted the @szdziedzic/add-repack-flag-to-build-command branch May 17, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants