Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "[eas-cli] Use expo-updates runtime version CLI to generate runtime ve…" (#2264)" #2265

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

wschurman
Copy link
Member

@wschurman wschurman commented Mar 6, 2024

Why

This reverts commit 2b59a5e.

Then, this applies a fix on top of it to support older SDKs.

How

Revert, re-test with SDK 45-50.

Test Plan

yarn create expo-app kjdasjkds555hjkdashjk50 --template blank@50
eas init
eas update:configure
~/expo/run-with-local-eas-build.sh build --local

(the last step uses a local eas-build to patch the revert in that repo: expo/eas-build#356)

Copy link

github-actions bot commented Mar 6, 2024

Size Change: -6.69 kB (0%)

Total Size: 51.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.3 MB -6.69 kB (0%)

compressed-size-action

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 37.73585% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 54.02%. Comparing base (2b59a5e) to head (3d9d111).

Files Patch % Lines
.../eas-cli/src/project/resolveRuntimeVersionAsync.ts 27.78% 13 Missing ⚠️
packages/eas-cli/src/project/publish.ts 35.72% 9 Missing ⚠️
packages/eas-cli/src/utils/expoUpdatesCli.ts 33.34% 6 Missing ⚠️
packages/eas-cli/src/project/projectUtils.ts 62.50% 3 Missing ⚠️
packages/eas-cli/src/build/metadata.ts 50.00% 1 Missing ⚠️
...kages/eas-cli/src/rollout/actions/CreateRollout.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2265      +/-   ##
==========================================
- Coverage   54.02%   54.02%   -0.00%     
==========================================
  Files         519      520       +1     
  Lines       18935    18961      +26     
  Branches     3798     3805       +7     
==========================================
+ Hits        10228    10242      +14     
- Misses       8686     8698      +12     
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 7, 2024

✅ Thank you for adding the changelog entry!

@wschurman wschurman requested a review from quinlanj March 7, 2024 02:32
@wschurman wschurman merged commit d78917b into main Mar 7, 2024
9 checks passed
@wschurman wschurman deleted the @wschurman/revert-revert-kjdsjkdsakhj branch March 7, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants