-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Revert "[eas-cli] Use expo-updates runtime version CLI to generate runtime ve…" (#2264)" #2265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wschurman
requested review from
szdziedzic,
khamilowicz and
sjchmiela
as code owners
March 6, 2024 17:59
wschurman
requested review from
quinlanj
and removed request for
sjchmiela and
khamilowicz
March 6, 2024 18:01
Size Change: -6.69 kB (0%) Total Size: 51.3 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2265 +/- ##
==========================================
- Coverage 54.02% 54.02% -0.00%
==========================================
Files 519 520 +1
Lines 18935 18961 +26
Branches 3798 3805 +7
==========================================
+ Hits 10228 10242 +14
- Misses 8686 8698 +12
Partials 21 21 ☔ View full report in Codecov by Sentry. |
quinlanj
approved these changes
Mar 6, 2024
quinlanj
reviewed
Mar 6, 2024
✅ Thank you for adding the changelog entry! |
quinlanj
approved these changes
Mar 7, 2024
szdziedzic
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This reverts commit 2b59a5e.
Then, this applies a fix on top of it to support older SDKs.
How
Revert, re-test with SDK 45-50.
Test Plan
(the last step uses a local eas-build to patch the revert in that repo: expo/eas-build#356)