Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-9772][eas-cli] don't ask user to install dev client if running in non-interactive mode #2124

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Nov 16, 2023

Why

https://linear.app/expo/issue/ENG-9772/prevent-interactive-cli-commands-in-build-configuration-step

We don't want to prompt users to install the dev client in non-interactive mode.

How

Instead of displaying the confirm prompt in non-interactive mode fail with a helpful error message.

Test Plan

Test locally
Screenshot 2023-11-16 at 17 38 56

Copy link

linear bot commented Nov 16, 2023

@szdziedzic
Copy link
Member Author

/changelog-entry bug-fix Don't ask a user to install the dev client if running in non-interactive mode

Copy link

✅ Thank you for adding the changelog entry!

Copy link

github-actions bot commented Nov 16, 2023

Size Change: -967 B (0%)

Total Size: 42.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 42.3 MB -967 B (0%)

compressed-size-action

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (a541a2e) 54.20% compared to head (7ead8bb) 54.19%.

Files Patch % Lines
packages/eas-cli/src/build/utils/devClient.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2124      +/-   ##
==========================================
- Coverage   54.20%   54.19%   -0.01%     
==========================================
  Files         509      509              
  Lines       18659    18663       +4     
  Branches     3741     3742       +1     
==========================================
  Hits        10113    10113              
- Misses       8525     8529       +4     
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@FiberJW FiberJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thumbs-up-11

@szdziedzic szdziedzic merged commit 50d78b0 into main Nov 17, 2023
9 checks passed
@szdziedzic szdziedzic deleted the @szdziedzic/dont-ask-user-to-install-dev-client-if-running-in-non-interactive-mode branch November 17, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants