Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone builds don't download EAS updates from channel #1469

Closed
antoinebrtd opened this issue Oct 20, 2022 · 6 comments
Closed

Standalone builds don't download EAS updates from channel #1469

antoinebrtd opened this issue Oct 20, 2022 · 6 comments
Labels
eas update needs review Issue is ready to be reviewed by a maintainer

Comments

@antoinebrtd
Copy link

antoinebrtd commented Oct 20, 2022

Build/Submit details page URL

https://expo.dev/accounts/the-ifc/projects/ifc-app/builds/5cf68b8f-a96b-446b-a5b3-70575a9ac496

Summary

I made a new Android build (runtime version 3.8.5) listening to the channel staging, downloaded the build on my Android device and made a change a few moments later to fix a small bug, which I published using eas update on the staging channel. The app doesn't download the update even after multiple cold launches. Tried for IOS, doesn't work either.

EAS Updates were working perfectly fine before, not sure if I changed something wrong in my project configuration.

Managed or bare?

managed

Environment

expo-env-info 1.0.5 environment info:
    System:
      OS: Linux 5.15 Ubuntu 22.04.1 LTS 22.04.1 LTS (Jammy Jellyfish)
      Shell: 5.8.1 - /usr/bin/zsh
    Binaries:
      Node: 16.9.1 - ~/.nvm/versions/node/v16.9.1/bin/node
      npm: 7.21.1 - ~/.nvm/versions/node/v16.9.1/bin/npm
    npmPackages:
      expo: ^46.0.0 => 46.0.7 
      react: 18.0.0 => 18.0.0 
      react-dom: 18.0.0 => 18.0.0 
      react-native: 0.69.6 => 0.69.6 
      react-native-web: ~0.18.7 => 0.18.7 
    npmGlobalPackages:
      eas-cli: 2.4.1
      expo-cli: 6.0.6
    Expo Workflow: managed
Didn't find any issues with the project!

Error output

No error, I run the following command and it works fine :

ENV=staging eas update --branch staging

Reproducible demo or steps to reproduce from a blank project

This is the Android build page I downloaded the build from :
Screenshot from 2022-10-20 17-06-37

The update was successful, with my update message :
Screenshot from 2022-10-20 17-07-16

The fix is working on the dev client, but the issue is still happening on staging app so the update didn't go through.The fix doesn't change the binary layer of the app, it is just a JS fix so it should have worked through the update.

Below my eas.json file :

{
  "cli": {
    "version": ">= 0.55.1"
  },
  "build": {
    "development": {
      "developmentClient": true,
      "distribution": "internal",
      "env": {
        "ENV": "development",
        "GOOGLE_SERVICES_FILE": "ignore warning"
      }
    },
    "preview": {
      "distribution": "internal",
      "channel": "staging",
      "env": {
        "ENV": "staging",
        "GOOGLE_SERVICES_FILE": "ignore warning"
      }
    },
    "production": {
      "channel": "production",
      "env": {
        "ENV": "production",
        "GOOGLE_SERVICES_FILE": "ignore warning"
      }
    }
  },
  "submit": {
    "production": {
      "android": {
        "serviceAccountKeyPath": "./google-service-account-key.json",
        "track": "production"
      },
      "ios": {
        "appleId": "[email protected]",
        "ascAppId": "appId",
        "appleTeamId": "teamId"
      }
    }
  }
}

app.json file :

{
  "expo": {
    "name": "IFC",
    "scheme": "ifc",
    "slug": "ifc-app",
    "owner": "the-ifc",
    "platforms": ["ios", "android"],
    "version": "3.8.7",
    "runtimeVersion": "3.8.5",
    "orientation": "portrait",
    "icon": "./src/assets/images/icon.png",
    "splash": {
      "image": "./src/assets/images/splash.png",
      "resizeMode": "contain",
      "backgroundColor": "#1c1c1c"
    },
    "updates": {
      "fallbackToCacheTimeout": 0,
      "url": "https://u.expo.dev/573595d7-8914-449c-b85a-6846ebd81a3c"
    },
    "plugins": [
      "sentry-expo",
      [
        "expo-notifications",
        {
          "icon": "./src/assets/images/badge.png",
          "color": "#df362a"
        }
      ]
    ],
    "assetBundlePatterns": ["**/*"],
    "ios": {
      "associatedDomains": ["applinks:the-ifc.fr"],
      "supportsTablet": false,
      "bundleIdentifier": "fr.theifc.IFC",
      "buildNumber": "61",
      "infoPlist": {
        "NSPhotoLibraryUsageDescription": "Ajout de photo sur la page équipe et sur votre profil depuis l'app.",
        "NSCameraUsageDescription": "Ajout de photos justificative, notamment pour les statistiques de match."
      }
    },
    "android": {
      "googleServicesFile": "./google-services.json",
      "intentFilters": [
        {
          "action": "VIEW",
          "autoVerify": true,
          "data": [
            {
              "scheme": "https",
              "host": "the-ifc.fr",
              "path": "/reinitialiser-mon-mdp"
            }
          ],
          "category": ["BROWSABLE", "DEFAULT"]
        }
      ],
      "package": "fr.theifc.IFC",
      "permissions": [
        "READ_EXTERNAL_STORAGE",
        "WRITE_EXTERNAL_STORAGE",
        "CAMERA",
        "CAMERA_ROLL"
      ],
      "blockedPermissions": ["android.permission.RECORD_AUDIO"],
      "versionCode": 61
    },
    "androidNavigationBar": {
      "backgroundColor": "#1c1c1c"
    },
    "androidStatusBar": {
      "barStyle": "light-content",
      "backgroundColor": "#1c1c1c"
    },
    "web": {
      "favicon": "./src/assets/images/icon.png"
    }
  }
}

app.config.js file :

import "dotenv/config";

let name = "App (Dev)";
let bundle = "bundle.dev";

if (process.env.ENV === "staging") {
  name = "App (preview)";
  bundle = "bundle.staging";
}
if (process.env.ENV === "production") {
  name = "App";
  bundle = "bundle";
}

export default ({ config }) => {
  return {
    ...config,
    name,
    ios: {
      ...config.ios,
      bundleIdentifier: bundle,
    },
    android: {
      ...config.android,
      package: bundle,
    },
    hooks: {
      postPublish: [
        {
          file: "sentry-expo/upload-sourcemaps",
          config: {
            organization: "org",
            project: "project",
            authToken: process.env.SENTRY_AUTH_TOKEN,
          },
        },
      ],
    },
    extra: {
      ...Config,
      eas: {
        projectId: "573595d7-8914-449c-b85a-6846ebd81a3c",
      },
    },
  };
};
@antoinebrtd antoinebrtd added the needs review Issue is ready to be reviewed by a maintainer label Oct 20, 2022
@antoinebrtd antoinebrtd changed the title Builds don't download EAS updates on device Standalone builds don't download EAS updates from channel Oct 20, 2022
@antoinebrtd
Copy link
Author

Any update on this?

@jferrettiboke
Copy link

@antoinebrtd My comment here might help you.

@antoinebrtd
Copy link
Author

antoinebrtd commented Nov 15, 2022

@jferrettiboke thanks, I am already using Constants.expoConfig.extra though, so might be another problem. When i open the update with expo dev client it works fine

@code-jenn-or
Copy link

@antoinebrtd I too am using Constants.expoConfig.extra and finding that when publishing an updating it is removing all of my secrets in the build. So I go from being able to fetch data to not being able to do anything with the app.

@giacomosardo
Copy link

I've try for example to write on terminal

API_URL="http://localhost:3000" eas update (my env and eas update)

and Constants.expoConfig.extra worked for me afert eas update.

@zenpi-me
Copy link

zenpi-me commented Nov 23, 2022

We are experiencing the same issue: EAS update works in dev but not in production. We also switched to Constants.expoConfig.extra

Expo SDK 46

Edit:
On dev we already upgraded expo to 47. Is it possible that this is the reason production update does not work anymore? Production is still on 46 thought.

Edit#2:
I discovered that we were updating with node_modules installed from staging. Meaning that SDK 47 was installed, even though I was checked out in master and wanted to update with SDK 46. Did this somehow screw up my expo channel?
Screenshot 2022-11-23 at 13 36 23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eas update needs review Issue is ready to be reviewed by a maintainer
Projects
None yet
Development

No branches or pull requests

6 participants