diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 3a66ad4dcc..5b2ba7b3c4 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -29,7 +29,7 @@ jobs: with: node-version: 18 - run: yarn install --frozen-lockfile --check-files - - run: yarn build + - run: yarn build-ci - name: Build tarballs working-directory: ${{ github.workspace }}/packages/eas-cli run: | @@ -70,7 +70,7 @@ jobs: with: node-version: 18 - run: yarn install --frozen-lockfile --check-files - - run: yarn build + - run: yarn build-ci - name: Build tarballs working-directory: ${{ github.workspace }}/packages/eas-cli run: | @@ -99,7 +99,7 @@ jobs: node-version: 18 - run: yarn install --frozen-lockfile --check-files - run: sudo apt-get install nsis - - run: yarn build + - run: yarn build-ci - run: | yarn pretarball-ci yarn oclif pack:win @@ -142,7 +142,7 @@ jobs: - name: Install dependencies run: yarn install --frozen-lockfile --check-files - name: Build - run: yarn build + run: yarn build-ci - name: Publish packages to npm run: yarn lerna publish from-package --yes --no-verify-access env: diff --git a/package.json b/package.json index 8005ddfd6a..e24756032e 100644 --- a/package.json +++ b/package.json @@ -6,6 +6,7 @@ ], "scripts": { "build": "lerna run build", + "build-ci": "lerna run build-ci", "build:tarballs:linux": "yarn build-for-size-check", "build-for-size-check": "yarn build && yarn workspace eas-cli pretarball-ci && CLI_SIZE_CHECK=1 yarn workspace eas-cli oclif pack:tarballs --no-xz --targets linux-x64", "typecheck": "lerna run typecheck", diff --git a/packages/eas-cli/package.json b/packages/eas-cli/package.json index b6a571532b..b459f242e2 100644 --- a/packages/eas-cli/package.json +++ b/packages/eas-cli/package.json @@ -204,11 +204,12 @@ "scripts": { "postpack": "rimraf oclif.manifest.json", "prepack": "yarn rebuild && node ./scripts/prepack.js", - "rebuild": "rimraf build && yarn build", + "rebuild": "rimraf build && yarn build-ci", "pretarball-ci": "./scripts/pretarball-ci.sh", "build": "tsc --project tsconfig.build.json", + "build-ci": "tsc --project tsconfig.build-ci.json", "watch": "yarn build --watch --preserveWatchOutput", - "typecheck": "tsc", + "typecheck": "tsc --project tsconfig.build-ci.json", "test": "jest", "version": "yarn oclif readme && node scripts/patch-readme && git add README.md", "generate-graphql-code": "graphql-codegen --config graphql-codegen.yml", diff --git a/packages/eas-cli/tsconfig.build-ci.json b/packages/eas-cli/tsconfig.build-ci.json new file mode 100644 index 0000000000..93ac83ef30 --- /dev/null +++ b/packages/eas-cli/tsconfig.build-ci.json @@ -0,0 +1,8 @@ +{ + "extends": "./tsconfig.build", + "compilerOptions": { + "noUnusedLocals": true, + "noUnusedParameters": true + }, + "exclude": ["**/__mocks__/*", "**/__tests__/*"] +} diff --git a/packages/eas-cli/tsconfig.json b/packages/eas-cli/tsconfig.json index 09d5e1f9bc..4f3a4cb3cb 100644 --- a/packages/eas-cli/tsconfig.json +++ b/packages/eas-cli/tsconfig.json @@ -7,8 +7,8 @@ "noFallthroughCasesInSwitch": true, "noImplicitOverride": true, "noImplicitReturns": true, - "noUnusedLocals": true, - "noUnusedParameters": true, + "noUnusedLocals": false, + "noUnusedParameters": false, "strict": true, "target": "ES2019", "outDir": "build", diff --git a/packages/eas-json/package.json b/packages/eas-json/package.json index e37fb6c40d..985a0a5393 100644 --- a/packages/eas-json/package.json +++ b/packages/eas-json/package.json @@ -34,10 +34,11 @@ "repository": "expo/eas-cli", "scripts": { "build": "tsc --project tsconfig.build.json", + "build-ci": "tsc --project tsconfig.build-ci.json", "watch": "yarn build --watch --preserveWatchOutput", - "typecheck": "tsc", + "typecheck": "tsc --project tsconfig.build-ci.json", "prepack": "yarn rebuild", - "rebuild": "rimraf build && yarn build", + "rebuild": "rimraf build && yarn build-ci", "test": "jest", "clean": "rimraf build node_modules yarn-error.log" }, diff --git a/packages/eas-json/tsconfig.build-ci.json b/packages/eas-json/tsconfig.build-ci.json new file mode 100644 index 0000000000..93ac83ef30 --- /dev/null +++ b/packages/eas-json/tsconfig.build-ci.json @@ -0,0 +1,8 @@ +{ + "extends": "./tsconfig.build", + "compilerOptions": { + "noUnusedLocals": true, + "noUnusedParameters": true + }, + "exclude": ["**/__mocks__/*", "**/__tests__/*"] +} diff --git a/packages/eas-json/tsconfig.json b/packages/eas-json/tsconfig.json index bf166a60a0..3d03822244 100644 --- a/packages/eas-json/tsconfig.json +++ b/packages/eas-json/tsconfig.json @@ -7,8 +7,8 @@ "noFallthroughCasesInSwitch": true, "noImplicitOverride": true, "noImplicitReturns": true, - "noUnusedLocals": true, - "noUnusedParameters": true, + "noUnusedLocals": false, + "noUnusedParameters": false, "strict": true, "target": "ES2019", "outDir": "build",