From 3ed5e7821e9ff842c129fd379449f3ff8dc087bb Mon Sep 17 00:00:00 2001 From: Szymon Dziedzic Date: Tue, 28 May 2024 11:51:41 +0200 Subject: [PATCH] [eas-cli] use correct app config for no gh `init:onboarding` flow (#2397) * [eas-cli] use correct app config for no gh `init:onboarding` flow * update CHANGELOG.md --- CHANGELOG.md | 2 ++ packages/eas-cli/src/commands/project/onboarding.ts | 6 ++++++ 2 files changed, 8 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index a6871c157f..e5343048a0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,8 @@ This is the log of notable changes to EAS CLI and related packages. ### ๐Ÿ› Bug fixes +- Use the correct app config for no GitHub flow in `init:onboarding`. ([#2397](https://github.com/expo/eas-cli/pull/2397) by [@szdziedzic](https://github.com/szdziedzic)) + ### ๐Ÿงน Chores ## [9.1.0](https://github.com/expo/eas-cli/releases/tag/v9.1.0) - 2024-05-23 diff --git a/packages/eas-cli/src/commands/project/onboarding.ts b/packages/eas-cli/src/commands/project/onboarding.ts index d6780ebc80..6a89c207cc 100644 --- a/packages/eas-cli/src/commands/project/onboarding.ts +++ b/packages/eas-cli/src/commands/project/onboarding.ts @@ -449,7 +449,11 @@ async function configureProjectFromBareDefaultExpoTemplateAsync({ ); Log.log(); + const baseExpoConfig = JSON.parse(await fs.readFile(path.join(targetDir, 'app.json'), 'utf8')) + .expo as ExpoConfig; + const expoConfig: ExpoConfig = { + ...baseExpoConfig, name: app.name ?? app.slug, slug: app.slug, extra: { @@ -465,9 +469,11 @@ async function configureProjectFromBareDefaultExpoTemplateAsync({ policy: 'appVersion', }, ios: { + ...baseExpoConfig.ios, bundleIdentifier, }, android: { + ...baseExpoConfig.android, package: bundleIdentifier, }, };