Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing English tokenizer exception: would've #1758

Closed
kwhumphreys opened this issue Dec 22, 2017 · 4 comments
Closed

missing English tokenizer exception: would've #1758

kwhumphreys opened this issue Dec 22, 2017 · 4 comments
Labels
enhancement Feature requests and improvements lang / en English language data and models

Comments

@kwhumphreys
Copy link
Contributor

add:

{ORTH: "would", NORM: "would", TAG: "MD"},

at https://github.com/explosion/spaCy/blob/master/spacy/lang/en/tokenizer_exceptions.py#L216

Your Environment

  • Operating System:
    macOS 10.13.2
  • Python Version Used:
    3.5.2
  • spaCy Version Used:
    2.0.5
  • Environment Information:
@ines ines added enhancement Feature requests and improvements lang / en English language data and models labels Dec 22, 2017
@ines
Copy link
Member

ines commented Dec 22, 2017

Good catch, thanks! If you have time, feel free to submit a PR 😊

@kwhumphreys
Copy link
Contributor Author

I have a PR but no permission to publish it

$ git push -u origin english-wouldve
remote: Permission to explosion/spaCy.git denied to kwhumphreys.
fatal: unable to access 'https://[email protected]/explosion/spaCy.git/': The requested URL returned error: 403

@ines
Copy link
Member

ines commented Jan 3, 2018

@kwhumphreys Sorry about the late reply! The best way to submit it is to fork spaCy, push your fix to your fork and then submit it here: https://github.com/explosion/spaCy/compare (Just select your fork in the "compare" dropdown and then click "Create pull request".)

@kwhumphreys kwhumphreys mentioned this issue Jan 3, 2018
Merged
3 tasks
@ines ines closed this as completed in 6a00823 Jan 4, 2018
@lock
Copy link

lock bot commented May 8, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Feature requests and improvements lang / en English language data and models
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kwhumphreys @ines