Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Allow discord webhooks aswell as slack #547

Closed
ghost opened this issue Nov 15, 2017 · 10 comments
Closed

[Feature Request] Allow discord webhooks aswell as slack #547

ghost opened this issue Nov 15, 2017 · 10 comments
Assignees
Milestone

Comments

@ghost
Copy link

ghost commented Nov 15, 2017

With discord being used just as much if not more than slack can you please allow webhooks to discord as well as slack because at the moment it's rejecting the input.
https://i.gyazo.com/5b538c94679e565e35ac2d584f0b41e1.png

Discord already has the ability to accept the slack format by just putting /slack on the end of a discord webhook.
https://discordapp.com/developers/docs/resources/webhook#execute-slackcompatible-webhook

@srmo
Copy link

srmo commented Nov 15, 2017

I like that idea. What would that enable? How does the interaction with discord look like?

@ghost
Copy link
Author

ghost commented Nov 15, 2017

It would be the same as slack. You can read more at https://discordapp.com/developers/docs/resources/webhook
Just that at the moment if I try to put another webhook url in other than one made by slack. it rejects the input.

@srmo
Copy link

srmo commented Nov 16, 2017

EDIT: deleted my old comments as I just figured that I was totally wrong, i.e. didn't know about the existing slack integration

@srmo
Copy link

srmo commented Nov 16, 2017

@Busterguy you could experiment by changing the pattern for the URL here:

<input name="slackWebHookURL" type="url" class="form-control" id="{{slackWebHookURLId}}" value="{{slackWebHookURL}}" placeholder="https://hooks.slack.com/services/XXX/YYY/ZZZ" data-type-error="No valid URL" pattern="^https://hooks.slack.com/.*" data-pattern-error="Wrong domain. https://hooks.slack.com/)">

The regex prevents you from trying out the discord URLs

@ghost
Copy link
Author

ghost commented Nov 16, 2017

Thanks. I’m not hosting my own at the moment.
But if I do later down the line il definitely try that.
This was mainly a suggestion for the master branch or whatever you call it.

@exodus4d
Copy link
Owner

Thanks for your suggestion. Ill think about that.
In the meantime you can use Slack as a "proxy" .... just use the existing Slack WebHook integration in a "Ghost" Slack channel (e.g. "private" or no users), just the Slack bot to pipe notifications from Pathfinder into Slack.
Then add an other Slack Integration (I´m sure there is a Discord Integration arround) and proxy all messages from that channel to your Discord.

A bit hakky but it should work ;)

@aalfath
Copy link

aalfath commented Nov 19, 2017

I managed to make Pathfinder work with Discord's webhook using the link provided by @Busterguy

It involved just 2 small hacks, particularly in the frontend validation mentioned by @srmo and a change to the slackWebHookURL field in the in map table in the DB. Somehow that field was set to store a maximum of 128 characters of string, but apparently the added /slack webhook URL requires 129 chars in total.

However, I'd say that so far it works really well...

@DLB82
Copy link

DLB82 commented Nov 22, 2017

I am interested by an operating procedure to connect a PathFinder hosted by myself & a discord channel as service.

@exodus4d exodus4d changed the title Allow discord webhooks aswell as slack [Feature Request] Allow discord webhooks aswell as slack Dec 10, 2017
@hilocz
Copy link

hilocz commented Dec 16, 2017

Anything new here ? It should be very easy to modify current Slack integration to be able use it for Discord. Now I need to hack into PF, because there are checks, which disallows to safe Discords webhook URL.

@exodus4d
Copy link
Owner

New feature: Discord integration

Here are some WIP screens:

Discord map settings:
rdg0ch4

Set rally point dialog:
i7jqv65

Discord:
ird5sck

@exodus4d exodus4d self-assigned this Dec 18, 2017
@exodus4d exodus4d added this to the v1.3.2 milestone Dec 18, 2017
@exodus4d exodus4d mentioned this issue Jan 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants