Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bringing your track in line with the latest changes to Problem Specifications #7

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

ErikSchierboom
Copy link
Member

We're in the process of re-opening the Problem Specifications repo, as discussed in this issue.
This PR adds .meta/tests.toml files for all exercises for which canonical data is defined in the Problem Specifications repo.
We'll now discuss why we're making this change.

Keeping track of implemented tests

While most of the changes to the Problem Specifications repo are specific to that repo, there is one track-specific change:

If a track implements an exercise for which test data exists, the exercise must contain a .meta/tests.toml file.
The goal of the tests.toml file is to keep track of which tests are implemented by the exercise.
Tests in this file are identified by their UUID and each test has a boolean value that indicates if it is implemented by that exercise.
A tests.toml file for a track's two-fer exercise looks like this:

[canonical-tests]
# no name given
"19709124-b82e-4e86-a722-9e5c5ebf3952" = true
# a name given
"3451eebd-123f-4256-b667-7b109affce32" = true
# another name given
"653611c6-be9f-4935-ab42-978e25fe9a10" = false

In this case, the track has chosen to implement two of the three available tests.
If a track uses a test generator to generate an exercise's test suite, it must use the contents of the tests.toml file to determine which tests to include in the generated test suite.

Tooling

To make it easy to keep the tests.toml up to date, tracks can use the canonical_data_syncer application.
This application is a small, standalone binary that will compare the tests specified in the tests.toml files against the tests that are defined in the exercise's canonical data.
It then interactively gives the maintainer the option to include or exclude test cases that are currently missing, updating the tests.toml file accordingly.
To use the canonical data syncer tool, tracks should copying the fetch-canonical_data_syncer and/or fetch-canonical_data_syncer.ps1 scripts into their repository.
Then, running either of these scripts will download the latest version of the tool to the track's bin directory.
The tool can be run using ./bin/canonical_data_syncer or .\bin\canonical_data_syncer.exe, depending on your operating system.

Changes

In this PR, we're adding meta/tests.toml files for all the exercises for which canonical data is defined.
We've initially marked all tests as included, which means that we'll assume that your track has implemented those tests.
If there isn't anything obviously wrong with the PR, I would suggest to merge this PR first, and then later on update the meta/tests.toml files according to your track's actual implementation.

@jaccarmac
Copy link
Contributor

Thanks for this! After the merge, I may get around to fixing the CI and trying to fill the repo out again.

Have merge commits been disabled for all Exercism repos? I had been using them here, but they seem to be disabled and I can't access the repo settings.

@ErikSchierboom
Copy link
Member Author

@jaccarmac I think @iHiD has indeed disabled merge commits globally. I think that you can request enabling them for a specific repo if you'd like that.

@iHiD
Copy link
Member

iHiD commented Oct 13, 2020

Yeah - we're preferring Squash and Merge as a general rule 🙂

@jaccarmac jaccarmac merged commit 7953c09 into master Oct 13, 2020
@jaccarmac jaccarmac deleted the pre-populate-data-for-exercises branch October 13, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants