Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable auto-format workflow #191

Open
SaschaMann opened this issue Mar 22, 2022 · 0 comments
Open

Add configurable auto-format workflow #191

SaschaMann opened this issue Mar 22, 2022 · 0 comments

Comments

@SaschaMann
Copy link
Contributor

SaschaMann commented Mar 22, 2022

Now that you can enable configlet fmt through .github/org-wide-files-config.toml, it would be convenient to also be able to add a synced workflow that allows people to trigger formatting through PR comments along the lines of /format in the old v3 repo.

E.g.

[configlet]
fmt = true
fmt-command = "/configlet-fmt"

or

[configlet]
fmt = true
fmt-command = true

Some issues:

  • Formatting requires a deploy key to be set up, so there'd be some initial manual labour involved. This could be achieved by posting an automated message pinging @iHiD whenever the workflow is first added. (Though that might annoy him)
  • Depending on the command, there might be overlap with /format. Though perhaps some people would want it to overlap if they have two compatible formatters set up. Making the command configurable like in the first example above would solve this, at the cost of complicating the workflow and losing cross-track consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant