Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matching-brackets exercise #203

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

keiravillekode
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Jan 6, 2024

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jan 6, 2024
@ErikSchierboom ErikSchierboom reopened this Jan 9, 2024
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two tiny formatting suggestions

Comment on lines 1 to 5
# | Register | Usage | Type | Description |
# | -------- | --------- | ------- | ------------------------------------------------- |
# | `$a0` | input | address | null-terminated input string |
# | `$v0` | output | boolean | input has matching brackets (`0` = `false`, `1` = `true`) |
# | `$t0-9` | temporary | any | used for temporary storage |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# | Register | Usage | Type | Description |
# | -------- | --------- | ------- | ------------------------------------------------- |
# | `$a0` | input | address | null-terminated input string |
# | `$v0` | output | boolean | input has matching brackets (`0` = `false`, `1` = `true`) |
# | `$t0-9` | temporary | any | used for temporary storage |
# | Register | Usage | Type | Description |
# | -------- | --------- | ------- | --------------------------------------------------------- |
# | `$a0` | input | address | null-terminated input string |
# | `$v0` | output | boolean | input has matching brackets (`0` = `false`, `1` = `true`) |
# | `$t0-9` | temporary | any | used for temporary storage |

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment on lines 5 to 9
| Register | Usage | Type | Description |
| -------- | --------- | ------- | ------------------------------------------------- |
| `$a0` | input | address | null-terminated input string |
| `$v0` | output | boolean | input has matching brackets (`0` = `false`, `1` = `true`) |
| `$t0-9` | temporary | any | used for temporary storage |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Register | Usage | Type | Description |
| -------- | --------- | ------- | ------------------------------------------------- |
| `$a0` | input | address | null-terminated input string |
| `$v0` | output | boolean | input has matching brackets (`0` = `false`, `1` = `true`) |
| `$t0-9` | temporary | any | used for temporary storage |
| Register | Usage | Type | Description |
| -------- | --------- | ------- | --------------------------------------------------------- |
| `$a0` | input | address | null-terminated input string |
| `$v0` | output | boolean | input has matching brackets (`0` = `false`, `1` = `true`) |
| `$t0-9` | temporary | any | used for temporary storage |

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@keiravillekode keiravillekode merged commit 361236a into exercism:main Jan 9, 2024
4 checks passed
@keiravillekode keiravillekode deleted the matching-brackets branch January 9, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants