From 7aa799831b7f6bc722ec5fabbd6c93f9125a94fd Mon Sep 17 00:00:00 2001 From: Logan Stucki Date: Tue, 9 May 2017 09:36:40 -0500 Subject: [PATCH 1/2] rna-transcription: rename "ofDna" with "transcribe" --- .../src/example/java/RnaTranscription.java | 2 +- .../src/main/java/RnaTranscription.java | 2 +- .../src/test/java/RnaTranscriptionTest.java | 12 ++++++------ 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/exercises/rna-transcription/src/example/java/RnaTranscription.java b/exercises/rna-transcription/src/example/java/RnaTranscription.java index 150aa9e9d..9382022ec 100644 --- a/exercises/rna-transcription/src/example/java/RnaTranscription.java +++ b/exercises/rna-transcription/src/example/java/RnaTranscription.java @@ -1,6 +1,6 @@ public class RnaTranscription { - public String ofDna(String strand) { + public String transcribe(String strand) { StringBuilder sb = new StringBuilder(); for (char c : strand.toCharArray()) { switch (c) { diff --git a/exercises/rna-transcription/src/main/java/RnaTranscription.java b/exercises/rna-transcription/src/main/java/RnaTranscription.java index a447ae0e2..452150737 100644 --- a/exercises/rna-transcription/src/main/java/RnaTranscription.java +++ b/exercises/rna-transcription/src/main/java/RnaTranscription.java @@ -1,5 +1,5 @@ public class RnaTranscription { - public String ofDna(String dnaString) { + public String transcribe(String dnaString) { throw new UnsupportedOperationException("Method has not been implemented yet."); } } \ No newline at end of file diff --git a/exercises/rna-transcription/src/test/java/RnaTranscriptionTest.java b/exercises/rna-transcription/src/test/java/RnaTranscriptionTest.java index 6b2dfc8a0..a409210b4 100644 --- a/exercises/rna-transcription/src/test/java/RnaTranscriptionTest.java +++ b/exercises/rna-transcription/src/test/java/RnaTranscriptionTest.java @@ -14,36 +14,36 @@ public void setUp() { @Test public void testRnaTranscriptionOfEmptyDnaIsEmptyRna() { - Assert.assertEquals("", rnaTranscription.ofDna("")); + Assert.assertEquals("", rnaTranscription.transcribe("")); } @Ignore("Remove to run test") @Test public void testRnaTranscriptionOfCytosineIsGuanine() { - Assert.assertEquals("G", rnaTranscription.ofDna("C")); + Assert.assertEquals("G", rnaTranscription.transcribe("C")); } @Ignore("Remove to run test") @Test public void testRnaTranscriptionOfGuanineIsCytosine() { - Assert.assertEquals("C", rnaTranscription.ofDna("G")); + Assert.assertEquals("C", rnaTranscription.transcribe("G")); } @Ignore("Remove to run test") @Test public void testRnaTranscriptionOfThymineIsAdenine() { - Assert.assertEquals("A", rnaTranscription.ofDna("T")); + Assert.assertEquals("A", rnaTranscription.transcribe("T")); } @Ignore("Remove to run test") @Test public void testRnaTranscriptionOfAdenineIsUracil() { - Assert.assertEquals("U", rnaTranscription.ofDna("A")); + Assert.assertEquals("U", rnaTranscription.transcribe("A")); } @Ignore("Remove to run test") @Test public void testRnaTranscription() { - Assert.assertEquals("UGCACCAGAAUU", rnaTranscription.ofDna("ACGTGGTCTTAA")); + Assert.assertEquals("UGCACCAGAAUU", rnaTranscription.transcribe("ACGTGGTCTTAA")); } } From 13406da0049bedb1cee1a8c0fbeba6088a8e89b7 Mon Sep 17 00:00:00 2001 From: Logan Stucki Date: Tue, 9 May 2017 12:01:15 -0500 Subject: [PATCH 2/2] Gave parameter more descriptive name --- .../rna-transcription/src/example/java/RnaTranscription.java | 4 ++-- .../rna-transcription/src/main/java/RnaTranscription.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/exercises/rna-transcription/src/example/java/RnaTranscription.java b/exercises/rna-transcription/src/example/java/RnaTranscription.java index 9382022ec..1ae632679 100644 --- a/exercises/rna-transcription/src/example/java/RnaTranscription.java +++ b/exercises/rna-transcription/src/example/java/RnaTranscription.java @@ -1,8 +1,8 @@ public class RnaTranscription { - public String transcribe(String strand) { + public String transcribe(String dnaStrand) { StringBuilder sb = new StringBuilder(); - for (char c : strand.toCharArray()) { + for (char c : dnaStrand.toCharArray()) { switch (c) { case 'A': sb.append('U'); diff --git a/exercises/rna-transcription/src/main/java/RnaTranscription.java b/exercises/rna-transcription/src/main/java/RnaTranscription.java index 452150737..0524c7661 100644 --- a/exercises/rna-transcription/src/main/java/RnaTranscription.java +++ b/exercises/rna-transcription/src/main/java/RnaTranscription.java @@ -1,5 +1,5 @@ public class RnaTranscription { - public String transcribe(String dnaString) { + public String transcribe(String dnaStrand) { throw new UnsupportedOperationException("Method has not been implemented yet."); } } \ No newline at end of file