Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace difference-of-squares with nucleotide-count on core track #789

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Replace difference-of-squares with nucleotide-count on core track #789

merged 1 commit into from
Dec 17, 2018

Conversation

sshine
Copy link
Contributor

@sshine sshine commented Dec 7, 2018

Nucleotide Count has several reasonable implementations and learning goals. Mentor notes are made available in exercism/website-copy#654 and the discussion to replace some core track exercises is advanced in #761.

@sshine
Copy link
Contributor Author

sshine commented Dec 7, 2018

I'm working on a Data.Text-based version of Nucleotide Count, but it involves mono-foldable which I haven't messed with before, so there's that.

Copy link
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ths PR has performed the replacement correctly, and the diff, as determined by running https://github.com/petertseng/exercism-problem-specifications/blob/list-tracks/tree.rb on both the original and new config.json, is as follows:

--- vine1	2018-12-07 23:14:05.000000000 +0000
+++ vine2	2018-12-07 23:14:21.000000000 +0000
@@ -3,7 +3,6 @@
 [deprecated] hexadecimal
 [deprecated] octal
 [deprecated] trinary
-[free] nucleotide-count
 [free] grade-school
 [free] isogram
 [free] diamond
@@ -74,7 +73,8 @@
     pig-latin
     say
     dominoes
-difference-of-squares
+nucleotide-count
+    difference-of-squares
     raindrops
     kindergarten-garden
     allergies

You are advised to take the following into consideration before merging: In Exercism v1, we had the rule to organise all side exercises in this file by difficulty. In Exercism v2, this does not make much sense anymore since it doesn't reflect the order that students will get the exercises. However, this will be the first commit to break that rule, if it is merged as-is. If now is the time to violate this rule, then it may also be a time to decide what the new rule might be.

  • Sort by (unlocking core exercise, difficulty)
  • Explicitly no order; wild west, anything goes.
  • Some other idea goes here

@petertseng
Copy link
Member

I will move the ordering discussion to #790.

Nucleotide Count has several reasonable implementations and learning
goals. Mentor notes are made available in exercism/website-copy#654 and
the discussion to replace some core track exercises is advanced in #761.

Until either its difficulty has been adjusted (#793) or another order
has been picked (#790), continue to order config.json by difficulty.
@sshine sshine merged commit a612d85 into exercism:master Dec 17, 2018
@sshine sshine deleted the replace-difference-of-squares-with-nucleotide-count branch March 12, 2019 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants