-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
difference-of-squares: Last test may be too hard for beginners #449
Comments
Let's see, looks like it was added in #255. And where was difference-of-squares before #402 moved it to be the fifth problem in the track? about 36th (I may have miscounted since I did it by hand). What would be the benefit of keeping it? To require students to think about efficiency? I'm about a 1/10 on the caring scale, but if you made me pick I'd vote to remove. |
I see two solutions:
Or a combination of the two. |
I'm usually against commenting out tests, because I think that users shouldn't have to read or edit them. A I agree with any of these three solutions:
I think that the first to open a PR should choose. What about it? 😄
I was just playing with gitbook to see how it works and also wanted to have a markdown file to play with Hakyll. Glad that you enjoyed! I would also like to have more examples, but I think that it should be a community thing. What would be the best way to allow people to contribute with refactoring examples and also allow people commenting the code, explaining parts that are not clear? I have no idea. |
I started with a strict implementation and it locked up my machine so hard I had to do a reset. Since this is to be expected there should be a giant warning in the solution template, or smarter test code. |
Sorry to hear that, @tewe! In the past we had a lot of test suites that used huge numbers or really big lists to test if an implementation was reasonable, forcing people to write efficient programs to pass the tests. Some of those tests where removed as we rewrote the test suites, but I guess you found one that is still there. 😄 In fact, we never decided if we should keep or not test cases about performance/memory. For now I'll just comment out this test, as @abo64 suggested, and open an issue to discuss the more general problem. |
Since I reviewed this iteration, I'm wondering if we should remove the last test case or move this exercise a little later in the track.
Most users try to solve this exercise using
sum
, and there is no way for that to work with a huge list.Other comments about it:
We are certainly missing more people reviewing the exercises...
There are two paths to pass the last test:
foldl'
.Should we do something about it? What?
The text was updated successfully, but these errors were encountered: