Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secure Treasure Chest - Error Instructions #363

Closed
rokf opened this issue Oct 8, 2023 · 1 comment · Fixed by #368
Closed

Secure Treasure Chest - Error Instructions #363

rokf opened this issue Oct 8, 2023 · 1 comment · Fixed by #368

Comments

@rokf
Copy link
Contributor

rokf commented Oct 8, 2023

The instructions on the Secure Treasure Chest exercise don't say what Error message (String) is expected to be set to.

I see two options:

  1. The messages are added into the descriptions.
  2. The tests are updated in such a way that the error message doesn't matter.

I'd personally prefer the second option since the error message doesn't really add anything to the exercise in my opinion 🙂
@lpil
Copy link
Member

lpil commented Oct 10, 2023

The former please. Thank you.

@rokf rokf mentioned this issue Oct 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve the secure treasure chest exercise instructions rokf/gleam
2 participants
@rokf @lpil