lint, fmt: support tags for approaches and concepts
#822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikSchierboom
force-pushed
the
analyzer-tags-support
branch
2 times, most recently
from
5a8edb2 to
81df8bb
Compare
ErikSchierboom
force-pushed
the
analyzer-tags-support
branch
from
81df8bb to
084484d
Compare
ErikSchierboom
commented
Oct 6, 2023
ee7
reviewed
Oct 6, 2023
Now exported from helpers, which is imported in this file.
ee7
reviewed
Oct 6, 2023
ee7
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
No diff to output of configlet lint on any track.
Diff in output of configlet fmt on exactly one track:
csharp
-The below paths are relative to '/home/foo/exercism-tracks/csharp'
-Not formatted: config.json
-Not formatted: exercises/practice/bank-account/.approaches/config.json
-Not formatted: exercises/practice/bob/.approaches/config.json
-Not formatted: exercises/practice/collatz-conjecture/.approaches/config.json
-Not formatted: exercises/practice/darts/.approaches/config.json
-Not formatted: exercises/practice/difference-of-squares/.approaches/config.json
-Not formatted: exercises/practice/diffie-hellman/.approaches/config.json
-Not formatted: exercises/practice/gigasecond/.approaches/config.json
-Not formatted: exercises/practice/grade-school/.approaches/config.json
-Not formatted: exercises/practice/grains/.approaches/config.json
-Not formatted: exercises/practice/hamming/.approaches/config.json
-Not formatted: exercises/practice/isogram/.approaches/config.json
-Not formatted: exercises/practice/leap/.approaches/config.json
-Not formatted: exercises/practice/pangram/.approaches/config.json
-Not formatted: exercises/practice/parallel-letter-frequency/.approaches/config.json
-Not formatted: exercises/practice/perfect-numbers/.approaches/config.json
-Not formatted: exercises/practice/phone-number/.approaches/config.json
-Not formatted: exercises/practice/pig-latin/.approaches/config.json
-Not formatted: exercises/practice/protein-translation/.approaches/config.json
-Not formatted: exercises/practice/proverb/.approaches/config.json
-Not formatted: exercises/practice/raindrops/.approaches/config.json
-Not formatted: exercises/practice/reverse-string/.approaches/config.json
-Not formatted: exercises/practice/rna-transcription/.approaches/config.json
-Not formatted: exercises/practice/series/.approaches/config.json
-Not formatted: exercises/practice/sieve/.approaches/config.json
-Not formatted: exercises/practice/two-fer/.approaches/config.json
-Not formatted: exercises/practice/yacht/.approaches/config.json
+Every exercise config is already formatted!
ee7
reviewed
Oct 6, 2023
ee7
approved these changes
Oct 6, 2023
ee7
changed the title
tags fieldtags for approaches and concepts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For background, see the forum thread.