Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Signs Issue #192

Closed
berinath3 opened this issue Sep 20, 2022 · 7 comments
Closed

Custom Signs Issue #192

berinath3 opened this issue Sep 20, 2022 · 7 comments
Assignees

Comments

@berinath3
Copy link

I wrote code for Custom Signs and it was executed in my local systems. But it was not executed on exercism. Please help me in that.

I am getting error .
error

Thanks,
Berinath Ulisi.

@larshp
Copy link
Member

larshp commented Sep 20, 2022

@berinath3 thanks, can you help by pasting the code here as text, so it can be used for reproducing?

@larshp
Copy link
Member

larshp commented Sep 20, 2022

hmm, looks like it can be reproduced with the empty implementation,

image

@larshp
Copy link
Member

larshp commented Sep 20, 2022

exercism/abap-test-runner#134
open-abap/open-abap-core#459

json escaping error,

image

@larshp larshp self-assigned this Sep 20, 2022
@berinath3
Copy link
Author

CLASS zcl_custom_signs DEFINITION
PUBLIC
FINAL
CREATE PUBLIC.

PUBLIC SECTION.

"! Build a sign that includes both of the parameters.
METHODS build_sign IMPORTING occasion      TYPE string
                             name          TYPE string
                   RETURNING VALUE(result) TYPE string.

"! Build a birthday sign that conditionally formats the return string.
METHODS build_birthday_sign IMPORTING age           TYPE i
                            RETURNING VALUE(result) TYPE string.

"! Build a graduation sign that includes multiple lines
METHODS graduation_for IMPORTING name          TYPE string
                                 year          TYPE i
                       RETURNING VALUE(result) TYPE string.

"! Determine cost based on each character of sign parameter that builds
"! the template string that includes the currency parameter.
METHODS cost_of IMPORTING sign          TYPE string
                          currency      TYPE string
                RETURNING VALUE(result) TYPE string.

ENDCLASS.

CLASS zcl_custom_signs IMPLEMENTATION.

METHOD build_sign.
"Implement solution here
result = |Happy { occasion } { name }!|.
ENDMETHOD.

METHOD build_birthday_sign.
"Implement solution here
if age >= 50.
result = |Happy Birthday! What a mature fellow you are.|.
else.
result = |Happy Birthday! What a young fellow you are.|.
endif.
ENDMETHOD.

METHOD graduation_for.
"Implement solution here
result = |Congratulations { name }!\nClass of { year }|.
ENDMETHOD.

METHOD cost_of.
"Implement solution here
result = |Your { sign } costs 58.00 { currency }.|.
ENDMETHOD.

ENDCLASS.

@berinath3
Copy link
Author

But it is working on my local system
error 1

@larshp
Copy link
Member

larshp commented Sep 20, 2022

@berinath3 try again, it should now give proper error messages,

image

@larshp larshp assigned berinath3 and unassigned larshp Sep 20, 2022
@berinath3
Copy link
Author

Ok Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants