Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document or automate how to rebase changes onto theme branches #46

Open
choldgraf opened this issue Oct 12, 2020 · 6 comments
Open

Document or automate how to rebase changes onto theme branches #46

choldgraf opened this issue Oct 12, 2020 · 6 comments
Labels
documentation Improvements or additions to documentation

Comments

@choldgraf
Copy link
Member

I just tried running

https://github.com/executablebooks/sphinx-panels/blob/master/git_rebase_theme_branches.sh

and ran into merge conflicts:

Using index info to reconstruct a base tree...
M       docs/conf.py
M       setup.py
Falling back to patching base and 3-way merge...
Auto-merging setup.py
CONFLICT (content): Merge conflict in setup.py
Auto-merging docs/conf.py
CONFLICT (content): Merge conflict in docs/conf.py
error: Failed to merge in the changes.
Patch failed at 0001 Change to alabaster theme

I'm not sure why - maybe I need to update some branches locally first or something?

Also worth noting I'm working form my fork (which is origin on my machine) while the script seems to hard-code origin expecting it to be this repository.

@choldgraf choldgraf added the documentation Improvements or additions to documentation label Oct 12, 2020
@chrisjsewell
Copy link
Member

chrisjsewell commented Oct 12, 2020

ah yeh I guess you need to working from the origin, not a fork (i.e. you are directly updating branches on the repo)

I just run it and it worked fine. You'll see now that all the theme branches are one commit ahead of master: https://github.com/executablebooks/sphinx-panels/tree/alabaster-theme

(linking my original explanation: #44 (comment))

@choldgraf
Copy link
Member Author

is this something we could automate with a on push to master github action?

@chrisjsewell
Copy link
Member

possibly 🤷 but I'm not sure how the permissions would work

@choldgraf
Copy link
Member Author

I think that if we only need to push to our own repository, then github actions already has permissions to take push actions against that same repo via the secrets.GITHUB_TOKEN variable

@chrisjsewell
Copy link
Member

Give it a go if you want. It should work, but I just don't want to go down a rabbit hole with it right now lol

@choldgraf
Copy link
Member Author

For sure - I don't think this is really crucial to tackle now, just wanted to note that piece of info for if we wanna tackle this in the future

@choldgraf choldgraf changed the title Document how to rebase changes onto theme branches Document or automate how to rebase changes onto theme branches Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants