You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Now that we've got this theme based on the latest PyData theme, we should see what we can "inherit" from that theme rather than re-creating the wheel here as well. This will help boost the maintainability of this theme, and make it easier for us to inherit upstream improvements when they are made.
Proposal
I propose that we do an audit of the following areas of this theme, and try to remove as much as we can while retaining the same end experience more or less:
CSS rules and variables
JavaScript functionality
HTML template structure
Python sphinx build infrastructure
There are probably a few places where we'll need to keep our own customizations (like margin content and the drop-down table of contents) but if we can cut out all of the stuff that's already done well in the pydata theme, this would help minimize confusion and unnecessary differences between them.
Tasks and updates
No response
The text was updated successfully, but these errors were encountered:
@AakashGfude I think that I have the most context about what we could try to remove, but I also have very little time to develop this theme right now, and also need to be focusing my efforts on the governance work for the project.
What do you think about this plan:
I take a stab at removing everything that I think I can remove. This will likely result in a slightly-broken version of the theme where some things are off.
I hand-off to you to make the necessary tweaks to get the theme back to where it was before in functionality
Context
Now that we've got this theme based on the latest PyData theme, we should see what we can "inherit" from that theme rather than re-creating the wheel here as well. This will help boost the maintainability of this theme, and make it easier for us to inherit upstream improvements when they are made.
Proposal
I propose that we do an audit of the following areas of this theme, and try to remove as much as we can while retaining the same end experience more or less:
There are probably a few places where we'll need to keep our own customizations (like margin content and the drop-down table of contents) but if we can cut out all of the stuff that's already done well in the pydata theme, this would help minimize confusion and unnecessary differences between them.
Tasks and updates
No response
The text was updated successfully, but these errors were encountered: