Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newer version of pydata-sphinx-theme could be used #423

Closed
erogluorhan opened this issue Nov 1, 2021 · 5 comments · Fixed by #429
Closed

Newer version of pydata-sphinx-theme could be used #423

erogluorhan opened this issue Nov 1, 2021 · 5 comments · Fixed by #429
Labels
enhancement New feature or request

Comments

@erogluorhan
Copy link

Description / Summary

Hi all,

The pydata-sphinx-theme dependency in setup.py is constrained as follows:

"pydata-sphinx-theme~=0.6.0"

pydata-sphinx-theme fixed significant bugs (e.g. Google analytics code snippet etc.) in their v0.7.0 and v0.7.1 recently, so this constraint here prevents us from taking advantage of those bug-fixes.

Is there a release coming soon? IF so, could you please consider revising this constraint in it?

Thanks!

Value / benefit

This would facilitate usage of the later/latest versions of pydata-sphinx-theme.

Implementation details

Something like following could be written in setup.py:

"pydata-sphinx-theme>=0.7.0"

instead of "pydata-sphinx-theme~=0.6.0".

Tasks to complete

No response

@erogluorhan erogluorhan added the enhancement New feature or request label Nov 1, 2021
@welcome
Copy link

welcome bot commented Nov 1, 2021

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

@kousu
Copy link
Contributor

kousu commented Nov 11, 2021

There's another motivation for this, that sphinx 4.3 just came out and broke this and its sibling themes: pydata/pydata-sphinx-theme#509

@kousu
Copy link
Contributor

kousu commented Nov 11, 2021

Is this done now? #406 got merged. It's just not released to pypi yet.

@chrisjsewell
Copy link
Member

I don't see any reason why this can't be released @choldgraf ?

@choldgraf
Copy link
Member

+1 from me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants