-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTD render doesn't show a .svg
logo?
#365
Comments
Yeah this entire section seems to be missing from rtd version? <div class="col-12 col-md-3 bd-sidebar site-navigation show" id="site-navigation">
<div class="navbar-brand-box">
<a class="navbar-brand text-wrap" href="#">
<img src="_static/tractor_logo_side.svg" class="logo" alt="logo">
<h1 class="site-logo" id="site-title">structured concurrent Python</h1>
</a>
</div> |
Possibly related to #364 (comment) when you say it doesn’t show for svg, is this because it does show for other image formats? |
Haven't tried other formats, so no, just providing the data point. Ok so I'll give that a shot. |
well it shouldn't be in principle, since you are not using sphinx v4, but can always give it a try. I'd note that I was literally just adding a new SVG logo to some of our other documentation, and this seems to be working ok: |
Lol indeed it seems to be there. |
Yah config for you: Looks the same as ours? Oddly the favicon looks fine? Hmm I wonder if it's because it doesn't have |
Oh wait, this is what I see on https://jupyter-cache--74.org.readthedocs.build/en/74/ Not sure if it's missing something? |
Yep I have One other thing I noticed, that may not have any relevance here, but you don't use an RTD configuration file e.g. https://github.com/executablebooks/jupyter-cache/blob/master/.readthedocs.yml |
What version of Sphinx are you building with? ReadTheDocs defaults to shipping with Sphinx 1.8, which... might be the culprit here? |
I believe that this is because you're using a custom See these docs for the stuff you can include: https://sphinx-book-theme.readthedocs.io/en/latest/customize/sidebar-primary.html#default-sidebar-elements closing this as I think it's a config issue, not a bug in the theme |
Describe the problem
A readthedocs render doesn't seem to show an
.svg
logo?Not sure where to look for the root cause of this.
Could it be some kind of rtd config we're missing?
A manual inspection of a local html versus rtd shows differences in the tree.
Link to your repository or website
https://tractor.readthedocs.io/en/latest/
Steps to reproduce
We're expecting it to look like:
The version of Python you're using
3.9
Your operating system
linux
Versions of your packages
No response
Additional context
I'll put up the html diff of interest if needed?
The text was updated successfully, but these errors were encountered: