Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose kernel_name of nbclient.nbexecute() #63

Closed
svenkreiss opened this issue Apr 9, 2021 · 6 comments
Closed

Expose kernel_name of nbclient.nbexecute() #63

svenkreiss opened this issue Apr 9, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@svenkreiss
Copy link

Is your feature request related to a problem? Please describe.

I cannot build jupyterbook without this fix.

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

My notebooks contain invalid kernel_names because of editing with VSCode. I want to override the kernel names when executed.

A clear and concise description of what you want to happen.

I want jupyterbook to be able to expose a kernel_name parameter in addition to the timeout parameter.

A clear and concise description of any alternative solutions or features you've considered.

I have added myself kernel_name='python3' in

and that fixed it.

Related to jupyter-book/jupyter-book#1287

@svenkreiss svenkreiss added the enhancement New feature or request label Apr 9, 2021
@welcome
Copy link

welcome bot commented Apr 9, 2021

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

@chrisjsewell
Copy link
Member

thanks @svenkreiss yes that sounds reasonable 👍
I'm slowly getting round to looking at improving myst-nb and execution, so will hopefully address this soon

@svenkreiss
Copy link
Author

Excellent! Thanks for your great work @chrisjsewell .

@joelostblom
Copy link

joelostblom commented Jun 4, 2021

To answer my own question that I originally wrote here: This would not work for conda kernels since the kernel itself is not seen by jupyter-book. I opened a separate issue in jupyter-book/jupyter-book#1348 and moved my original comment there.

@chrisjsewell
Copy link
Member

As noted in jupyter-book/jupyter-book#1287, the issue with VS Code is now fixed, in that it now sets standard kernel names like 'python3': microsoft/vscode-jupyter#5732

(this not to say though that there is not still a use case here)

@chrisjsewell
Copy link
Member

I would this is now closed by: executablebooks/MyST-NB#410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants