Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 Nested parse attribution in attr_block #831

Merged
merged 3 commits into from
Nov 24, 2023

Conversation

chrisjsewell
Copy link
Member

This is in keeping with the restructured text implementation, e.g.

  Hallo

  -- Chris Sewell `link <https://source.com>`__

tokenizes to:

<document source="test.rst">
    <block_quote>
        <paragraph>
            Hallo
        <attribution>
            Chris Sewell 
            <reference name="link" refuri="https://source.com">
                link

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (635d74f) 90.26% compared to head (c7a35c7) 90.26%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #831   +/-   ##
=======================================
  Coverage   90.26%   90.26%           
=======================================
  Files          23       23           
  Lines        2969     2970    +1     
=======================================
+ Hits         2680     2681    +1     
  Misses        289      289           
Flag Coverage Δ
pytests 90.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisjsewell chrisjsewell linked an issue Nov 24, 2023 that may be closed by this pull request
@chrisjsewell chrisjsewell changed the title 👌 Nested parse attribution in attr_block 👌 Nested parse attribution in attr_block Nov 24, 2023
@chrisjsewell chrisjsewell merged commit 1f61fa0 into master Nov 24, 2023
21 checks passed
@chrisjsewell chrisjsewell deleted the nested-parse-attr-attribute branch November 24, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for links links and titles in block quote attributions
1 participant