Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pending deprecation warning in Sphinx 8 #645

Closed
agoose77 opened this issue Oct 30, 2024 · 3 comments · Fixed by #647
Closed

Pending deprecation warning in Sphinx 8 #645

agoose77 opened this issue Oct 30, 2024 · 3 comments · Fixed by #647
Labels
bug Something isn't working

Comments

@agoose77
Copy link
Collaborator

See CI in sphinx-book-theme
@bsipocz bsipocz mentioned this issue Oct 30, 2024
Merged
@flying-sheep
Copy link
Contributor

flying-sheep commented Nov 11, 2024 •
edited
Loading

Is it this?

sphinx.deprecation.RemovedInSphinx10Warning: 'sphinx.util.import_object' is deprecated. Check CHANGES for Sphinx API modifications.

because that also exists

@bsipocz bsipocz added the bug Something isn't working label Nov 11, 2024
@bsipocz
Copy link
Collaborator

bsipocz commented Nov 11, 2024

I'm trying to hunt down all these remaining issues. Where do you both see these? Any links to failing builds/or logs would be super useful.

@flying-sheep
Copy link
Contributor

flying-sheep commented Nov 11, 2024 •
edited
Loading

Where do you both see these?

Code search told me

MyST-NB/myst_nb/core/read.py

Line 61 in aee9a46

from sphinx.util import import_object

So no log necessary, that line simply performs a deprecated import.

@bsipocz bsipocz mentioned this issue Nov 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TST: fail on warnings bsipocz/MyST-NB
3 participants
@flying-sheep @agoose77 @bsipocz