Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MyST-nb injects CSS for ipywidgets that ignores dark mode #618

Open
flying-sheep opened this issue Aug 5, 2024 · 2 comments
Open

MyST-nb injects CSS for ipywidgets that ignores dark mode #618

flying-sheep opened this issue Aug 5, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@flying-sheep
Copy link
Contributor

flying-sheep commented Aug 5, 2024

Describe the bug

context

When adding a output to a ipywidgets widget, e.g. a <table class=table>…</table> to a VBox, the resulting style partially ignores dark mode.

image image

expectation
I expected tables and ipywidget UI to be dark-mode aware.

I expect CSS for cell output to never use hardcoded colors, but always CSS variables.

bug
But instead light-on-dark elements appear in the cell output

problem
This is a problem because it’s ugly and every second line is unreadable.

Reproduce the bug

See https://github.com/flying-sheep/session-info2/blob/da3827c26259211e3a0d2effa9695422436fe562/src/session_info2/_widget.py#L39-L43

Which results in this HTML: https://session-info2.readthedocs.io/en/latest/

Specifically this applies:

div.cell_output tbody tr:nth-child(odd) {
  background: #f5f5f5;
}

Please never use hardcoded colors in CSS, only variables

List your environment

  • Python 3.12
  • myst-nb 1.1.1
@flying-sheep
Copy link
Contributor Author

Hi @agoose77 do you have any ideas how the maintenance situation here can be improved? I’d like to try my hand at fixing this, but my experience with #597 is suggesting that doing so would need a lot of prodding and patience on my part.

I’d love to contribute if feedback, PR merges, and releases would be halfway quick. Is there a way we can make that happen?

@bsipocz
Copy link
Collaborator

bsipocz commented Nov 25, 2024

I’d love to contribute if feedback, PR merges

I haven't dived into all the open PRs, but will definitely keeping an eye open to all new incoming bugfixes which we hope takes off some bites from the other maintainers' plates. Therefore bugfix releases can become more timely.

So please keep that PR coming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants