Unable to pass arguments to email methods

[tomrossi7]

I'm not sure if this follows the opinion of Noticed, but some mailer methods accept both params and arguments. I believe the current email_format method only really sets the params. So for example, Noticed can't send an email notification to a mailer method like this:

UserMailer.with({ recipient: User.first }).new_comment(comment)

Is this something Noticed should support? If so, I can take a crack at a PR.

[excid3]

I'm not sure. How do you envision the user defining those it in their Notification object?

[tomrossi7]

I set up my own custom delivery method and this is how I specified the params and args. I kinda like email_params better than email_format since its more explicit.

  def email_args
    params[:comment]
  end

  def email_params
    { recipient: params[:recipient] }
  end

The recipient is merged so it isn't necessary, but I'm just showing how it would work if you did have other params to pass.

[excid3]

So a complete example might look like this:

class CommentNotification < Noticed::Base
  delivers_by :email, mailer: "UserMailer", params: :params_for_email, arguments: :args_for_email

  # Should return an array of arguments 
  def arguments_for_email
    [comment, post]
  end

  def params_for_email
    {}
  end
end

Seems fine to me. 👍

For backwards compatibility, we'd need to support format: but add a deprecation warning if used.

[tomrossi7]

Yep! I need to make sure it works with named arguments as well, but will put together a PR for you to check out when I get a chance!

[excid3]

While you're in there, would you mind changing send for the mailer method to public_send? We shouldn't be calling any private methods (or allowing that). 🙃

[tomrossi7]

You bet! Thanks @excid3 for putting this code together!