Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages & fix package issues #230

Merged
merged 5 commits into from
Jan 17, 2020
Merged

Update packages & fix package issues #230

merged 5 commits into from
Jan 17, 2020

Conversation

SeanKilleen
Copy link
Contributor

This attempts to recreate what failed on the dependabot merge and see if I can isolate/fix the problem.

@SeanKilleen SeanKilleen self-assigned this Jan 17, 2020
@SeanKilleen SeanKilleen changed the title Update packages Update packages & fix package issues Jan 17, 2020
<PackageReference Include="Microsoft.ApplicationInsights.AspNetCore" Version="2.12.0" />
<PackageReference Include="Microsoft.AspNetCore.Authentication" Version="2.2.0" />
<PackageReference Include="Microsoft.AspNetCore.Authentication.AzureAD.UI" Version="3.1.0" />
<PackageReference Include="Microsoft.AspNetCore.Authentication.MicrosoftAccount" Version="3.1.0" />
<PackageReference Include="Microsoft.AspNetCore.Authentication.AzureAD.UI" Version="3.1.1" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be the issue. Independent of other package updates, taking this to v3.1.1 causes a 500 error:

System.IO.FileNotFoundException
  HResult=0x80070002
  Message=Could not load file or assembly 'Microsoft.AspNetCore.Razor.Runtime, Version=3.1.1.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'. The system cannot find the file specified.
  Source=<Cannot evaluate the exception source>
  StackTrace:
<Cannot evaluate the exception stack trace>

@SeanKilleen
Copy link
Contributor Author

FYI issues with this package are being tracked at dotnet/aspnetcore#18334, per MS thread on my opened issue.

@SeanKilleen
Copy link
Contributor Author

Since the referenced MS issue was closed and generally referred to an issue with v3.1.1 packages, I'm going to hold off on those for now and tell Dependabot to skip them.

@SeanKilleen SeanKilleen merged commit 72f2d10 into master Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant