Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad background color in _DEFAULT_ENGINE_OPTIONS #3110

Open
spustlik opened this issue Jun 23, 2024 · 4 comments
Open

Bad background color in _DEFAULT_ENGINE_OPTIONS #3110

spustlik opened this issue Jun 23, 2024 · 4 comments
Labels
stale This issue or PR has not had any activity recently

Comments

@spustlik
Copy link

line 705:

    backgroundColor: Color.fromHex('#2185d0') // Excalibur blue

should be

    backgroundColor: Color.ExcaliburBlue

Environment

  • Excalibur versions: v0.30.0-alpha.1068+436d3b1
@Autsider666
Copy link
Contributor

Autsider666 commented Jun 29, 2024

Correct me if I'm wrong, but I'm 93% sure it's not the intention of @spustlik to call the usage of Color.fromHex bad, but point out the difference between the used hex color in the engine (#2185d0, from here on out EngineBlue) vs the hex color used in Color.ExcaliburBlue (#176BAA, from here on out ExcaliburBlue).

These seem to be used interchangeably all throughout the codebase, so some time should probably be taken to pick the "official" EX hex color to consistently use everywhere.

EngineBlue

ExcaliburBlue

@eonarheim
Copy link
Member

@Autsider666 Many thanks for digging into this, I'll dig through and sort this out and make it consistent.

Who knows what past Erik was thinking here :/

@Autsider666
Copy link
Contributor

I've some free time to fix this. I'd just need to know what the "real" ExcaliburBlue color is out of these 2.

Copy link

This issue hasn't had any recent activity lately and is being marked as stale automatically.

@github-actions github-actions bot added the stale This issue or PR has not had any activity recently label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale This issue or PR has not had any activity recently
Projects
None yet
Development

No branches or pull requests

3 participants