Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Docker Setup in Github Actions #96

Open
tkilias opened this issue Mar 26, 2024 · 0 comments
Open

Check Docker Setup in Github Actions #96

tkilias opened this issue Mar 26, 2024 · 0 comments
Labels
refactoring Code improvement without behavior change

Comments

@tkilias
Copy link
Collaborator

tkilias commented Mar 26, 2024

The test_itde_manager.py assumes that, we run on the host and not in a container. However, certain CI do a docker-in-docker setup by mounting the docker-socket in the container which runs the CI scripts. This would change what we test in these tests, and that should be avoided.

Idea: Add docker ps -a to the Github Workflow and check if you a see a container that is not yours

Further, we maybe should add a check if we are in a container or not to these tests.

If the Github CI is running in a Container then we probably need to parameterize

def docker_container(wheel_path, docker_image,
to create two containers one with the default docker network and one with a host network.

@tkilias tkilias added the refactoring Code improvement without behavior change label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code improvement without behavior change
Projects
None yet
Development

No branches or pull requests

1 participant