You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The test_itde_manager.py assumes that, we run on the host and not in a container. However, certain CI do a docker-in-docker setup by mounting the docker-socket in the container which runs the CI scripts. This would change what we test in these tests, and that should be avoided.
Idea: Add docker ps -a to the Github Workflow and check if you a see a container that is not yours
Further, we maybe should add a check if we are in a container or not to these tests.
If the Github CI is running in a Container then we probably need to parameterize
The test_itde_manager.py assumes that, we run on the host and not in a container. However, certain CI do a docker-in-docker setup by mounting the docker-socket in the container which runs the CI scripts. This would change what we test in these tests, and that should be avoided.
Idea: Add docker ps -a to the Github Workflow and check if you a see a container that is not yours
Further, we maybe should add a check if we are in a container or not to these tests.
If the Github CI is running in a Container then we probably need to parameterize
notebook-connector/test/integration/test_itde_manager_in_docker_container.py
Line 188 in ad39d29
The text was updated successfully, but these errors were encountered: