This created a regression where resolvers that do not *return* a BatchLoader::GraphQL fail to call BatchLoader::GraphQL calls that the resolver uses.

[maletor]

This created a regression where resolvers that do not return a BatchLoader::GraphQL fail to call BatchLoader::GraphQL calls that the resolver uses.

Originally posted by @maletor in #32 (comment)

[ghost]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[exAspArk]

Hi @maletor,

Do you use graphql gem versions >= 1.8.7?

• If yes, then upgrading to batch-loader version 1.3.0 should have no effect for resolvers which don't return BatchLoader::GraphQL. With graphql 1.8.7+, batching was already broken because of the breaking changes in the graphql gem.
• If you use version graphql gem versions < 1.8.7, then resolvers with BatchLoader::GraphQL and without should work fine. I.e. it is backward compatible.

Here is the test schema which covers this case:

batch-loader/spec/fixtures/graphql_schema.rb

Lines 10 to 20 in 43e4f62

	field :user, !UserType, resolve: ->(object, args, ctx) do
	BatchLoader::GraphQL.for(object.user_id).batch do |user_ids, loader|
	User.where(id: user_ids).each { |user| loader.call(user.id, user) }
	end
	end
	field :userOld, !UserType, resolve: ->(object, args, ctx) do
	BatchLoader.for(object.user_id).batch do |user_ids, loader|
	User.where(id: user_ids).each { |user| loader.call(user.id, user) }
	end
	end

[ghost]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.