Generate commit bins and release bins

[ewowi]

Generate commit bins and release bins is currently not working as it should.

In StarMod .github/workflows/pio.yml generates this

Current situation:

• commit bins: StarMod-esp32-${{env.git_branch}}-${{env.git_hash}}.bin generated from .pio/build/esp32dev/firmware.bin
• release bins: nothing generated

Desired situation: for both commit bins and release bins, a bin should be generated for each env in pio.ini following the same syntax as local vscode/pio build file names:

• {$APP}{$VERSION}{$PIOENV}.bin e.g. StarMod_24041415_esp32dev.bin, variables are defined in pio.ini
• see tools/post_build: builds local files in ~/Downloads and GitHub builds in GitHub/ewowi/StarMod/build_output/release

To be done:

• Get inspired by Github/MoonModules/WLED/.github/workflows/wlec-ci.yml (copy-refactor-paste / MVP (Minimum Viable Product))
  • don't use build_output/firmware and build_output/map (unless good reason)
  • don't use .bin.gz (unless good reason)
  • take all the envs per default, no need to implement default_envs (unless good reason)
  • use the code to take bin files from build_output/release and upload artifacts and release
• add this to pio.yml
• make changes to post_build.py if needed

[ewowi]

In current situation normal commits run fine.

Creating a release results in error:

See also pio.yml: Upload Artifact:

For some reason it expects something else if release is created

Might be that if this error is solved, release bins are also generated

[ewowi]

Created the first baseline releases for StarMod and StarLeds - bins have been added manually - workflows have failed due to above error

https://github.com/MoonModules/StarModLeds/releases/tag/v0.0.0

https://github.com/ewowi/StarMod/releases/tag/v0.0.0

[netmindz]

#49

[netmindz]

https://github.com/ewowi/StarMod/releases/tag/untagged-76e95c834a3a564dfa28

[netmindz]

Can now create builds with the right assets for release and regular builds now using the build cache and with matrix so just over a minute rather then just under 7 mins

[ewowi]

Is it possible to have the file names like this?:
{$APP}{$VERSION}{$PIOENV}.bin e.g. StarMod_24041415_esp32dev.bin, variables are defined in pio.ini

Both in actions/artifacts and in releases:

->

So it is consistent with the file names generated by post_build.py

And for user friendlyness, is it possible to list every file in actions.artifacts instead of a zip file, so user can see immediately which files are available

[netmindz]

So the naming is {$APP}-{$PIOENV}-{$VERSION}-{$GITSHA}.bin

I think having the env name first makes it easier to see you are using the write image for the right hardware, then the next most important thing is the version. If the version is the branch name then you also need the gitsha so you can be sure you are testing what you think you are. When using a release tag, then the gitsha is redundant, but as it's at the end then not really too much of an issue

I don't follow your comment about the zip file, the assets are not zips, but the image ready to use now

[ewowi]

In the release assets you see individual bins but in actions / artifacts I see only one file, which, if downloaded is a zip file containing all bins:

[ewowi]

WLED shows them individually:

[netmindz]

Fixed here #53

[ewowi]

One step closer ;-)!

Only names should be same as names generated by VSCode/PIO:

APP, PIOENV and VERSION is used for this and is defined in platformio.ini

[netmindz]

What is actually creating that build number? Is it just date and time?

[netmindz]

Generally for CI builds the assets should be given a naming that matches the source code version so you can trace that back to the right source code

[ewowi]

Bins are also not generated in a release, was also something similar mentioned for WLED MM recently? @netmindz any ideas what we can do to have bins with the right naming generated?