RSeQC: check for division by zero #2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ewels
reviewed
Sep 14, 2023
Comment on lines
+51
to
+52
| if total == 0: | ||
| continue |
There was a problem hiding this comment.
Should add a warning log message here
ewels
reviewed
Sep 14, 2023
| @@ -30,6 +30,7 @@ | |||
| - Do not fail when all input samples have no coverage ([#2005](https://github.com/ewels/MultiQC/pull/2005)). | |||
| - **RSeQC** | |||
| - Fix "max() arg is an empty sequence" error ([#1985](https://github.com/ewels/MultiQC/issues/1985)) | |||
| - Fix division by zero on all-zero input ([#2040](https://github.com/ewels/MultiQC/pull/2040)) | |||
There was a problem hiding this comment.
Suggested change
| - Fix division by zero on all-zero input ([#2040](https://github.com/ewels/MultiQC/pull/2040)) | |
| - Fix division by zero on all-zero input to inner-distance ([#2040](https://github.com/ewels/MultiQC/pull/2040)) |
ewels
approved these changes
Sep 14, 2023
|
Auto merge |
|
Re log message - I don't think it's needed as the sample data will stay in the report. We just make it skip converting 0 "things" into 0 percents. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2033