Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unused Dependency: Simplejson #1973

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Remove Unused Dependency: Simplejson #1973

merged 2 commits into from
Aug 15, 2023

Conversation

gdrosos
Copy link
Contributor

@gdrosos gdrosos commented Aug 11, 2023

Summary

This pull request removes the unused dependency simplejson from the setup.py configuration file. The removal of this dependency is a finding from ongoing research aimed at identifying and eliminating code bloat within software projects.

Rationale

The simplejson library was previously used within the project but was deemed unnecessary and removed in favor of json in cf37100. Despite its removal from the source code, simplejson remained listed as a requirement in the project's configuration file. Removing this unused dependency reduces the overall footprint of the application, mitigating potential security risks, and simplifying the dependency management process.

Changes

  • Removed the simplejson dependency from the setup.py file.
  • Updated changelog.

Impact

  • Reduced Package Size: The removal of this unused dependency will lead to a decrease in the overall size of the installed packages.

  • Simplified Dependency Tree: Fewer dependencies make the project easier to maintain and can speed up installation.

  • This comment contains a description of changes (with reason)

  • CHANGELOG.md has been updated

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, great spot - thanks!

@ewels ewels merged commit 9ea23fa into MultiQC:master Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants