Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rna quant metrics for dragen 4.2 #1958

Merged
merged 2 commits into from
Jul 30, 2023
Merged

Update rna quant metrics for dragen 4.2 #1958

merged 2 commits into from
Jul 30, 2023

Conversation

alexiswl
Copy link
Contributor

Dragen 4.2 uses suffix .quant_metrics.csv as opposed to previous versions .quant.metrics.csv.

ewels
ewels approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This should probably be done outside of the module using sample name cleaning patterns, instead of a regex in the code to be honest. Then it would be configurable by the end user. But we can leave that for another day.

@ewels ewels merged commit ab095c8 into MultiQC:master Jul 30, 2023
11 checks passed
@alexiswl
Copy link
Contributor Author

alexiswl commented Aug 9, 2023

Ah sorry @ewels looks like I didn't commit the search patterns file for this one. Adding it in now under a separate PR

@alexiswl alexiswl mentioned this pull request Aug 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewels ewels ewels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexiswl @ewels