optimize linegraph category comparison #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! 👏🏻 Sounds like it's worth celebrating so therefore worth a changelog entry 🍾🥳 |
|
Updated changelog! |
ewels
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizes the category comparison of the linegraph.
See the issue is,
d["data"]does not change while looping throughd["data"]as best I can tell. So every iteration, the result will be the same. The only thing we need to check is that the values are lists. Once we verify that, we just need to check categories once per dataset.In one case, I was comparing a list of 68000 cats, 68000 times. This is an n^2 problem, no bueno.
The fix brought multiqc from not on a dataset to finishing in ~20s.
CHANGELOG.mdhas been updatedI didn't think this was worthy of CHANGELOG, lmk if you feel otherwise