Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply color in sample selection in Toolbox not using the correct color #742

Closed
kjellp opened this issue Apr 23, 2018 · 2 comments
Closed
Labels
bug: core Bug in the main MultiQC code
Milestone

Comments

@kjellp
Copy link

kjellp commented Apr 23, 2018

Description of bug:
I wanted to change the colors of the selected sample lines in FastQC: Adapter content. But discovered that the desired colors were not applied when following this procedure:

  1. Changing the color in the Toolbox user interface (highlight section)
  2. then selecting the samples to highlight in the color coded Samples summary behind the "Adapter Content" header, using "Highlight these samples" in the context menu of 2 failed samples
    The samples were highlighted, but seems to be using the color pre-selected in the toolbox UI before changing it in step 1).

MultiQC Error log:
nothing relevant

  • File that triggers the error:
  • Command used to run MultiQC
    • multiqc basic_RNAseq
  • MultiQC Version:
    • MultiQC v1.5
  • Operating System:
    • Xubuntu 14.04
  • Python Version:
    • Python 2.7.12
  • Method of MultiQC installation:
    • pip
@ewels ewels added the bug: core Bug in the main MultiQC code label May 8, 2018
@ewels ewels added this to the MultiQC v1.8 milestone Nov 13, 2019
@ewels
Copy link
Member

ewels commented Nov 19, 2019

I've finally come to fixing this issue! After a quick bit of digging, I realise that this is a FastQC specific request - from this dialogue only:
image

And as you say, this highlight feature does not respect the colour that has been chosen in the toolbox.

@ewels ewels closed this as completed in 707a01a Nov 19, 2019
@ewels
Copy link
Member

ewels commented Nov 19, 2019

Ok, only a tiny change for the fix, but now done. Sorry that it took me over a year!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: core Bug in the main MultiQC code
Projects
None yet
Development

No branches or pull requests

2 participants