Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MirTop still broken (isomiR_perc) #1719

Closed
apeltzer opened this issue Jul 4, 2022 · 5 comments · Fixed by #1723
Closed

MirTop still broken (isomiR_perc) #1719

apeltzer opened this issue Jul 4, 2022 · 5 comments · Fixed by #1723
Assignees
Labels
bug: module Bug in a MultiQC module

Comments

@apeltzer
Copy link
Contributor

apeltzer commented Jul 4, 2022

Description of bug

@ErikDanielsson - your latest bugfix fixed half of the low coverage issues we saw :-( Can we have such a defaulting to zero for all cases where there is a float division done in MultiQC? That would permanently fix it then...

#1712

image

File that triggers the error

No response

MultiQC Error log

|         searching | ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 420/420
|    custom_content | nf-core-smrnaseq-summary: Found 1 sample (html)
|    custom_content | software_versions: Found 1 sample (html)
╭───────────────── Oops! The 'mirtop' MultiQC module broke... ─────────────────╮
│ Please copy this log and report it at                                        │
│ https://github.com/ewels/MultiQC/issues                                      │
│ Please attach a file that triggers the error. The last file found was:       │
│ ./93/full_mirtop_stats.log                                                   │
│                                                                              │
│ Traceback (most recent call last):                                           │
│   File "/usr/local/lib/python3.10/site-packages/multiqc/multiqc.py", line 65 │
│     output = mod()                                                           │
│   File "/usr/local/lib/python3.10/site-packages/multiqc/modules/mirtop/mirto │
│     self.parse_mirtop_report(f)                                              │
│   File "/usr/local/lib/python3.10/site-packages/multiqc/modules/mirtop/mirto │
│     parsed_data["isomiR_perc"] = (parsed_data["isomiR_sum"] / parsed_data["r │
│ ZeroDivisionError: float division by zero                                    │
│                                                                              │
╰──────────────────────────────────────────────────────────────────────────────╯
|          samtools | Found 158 stats reports
|            fastqc | Found 79 reports
|           multiqc | Compressing plot data
|           multiqc | Report      : multiqc_report.html
|           multiqc | Data        : multiqc_data
|           multiqc | Plots       : multiqc_plots
|           multiqc | MultiQC complete
|           multiqc | 1 flat-image plot used in the report due to large sample numbers
|           multiqc | To force interactive plots, use the '--interactive' flag.
See the documentation.
@ewels
Copy link
Member

ewels commented Jul 4, 2022

@apeltzer is this will the example data in MultiQC/test-data#227 ? If not, please could you provide some more? 😀

@ewels ewels added the bug: module Bug in a MultiQC module label Jul 4, 2022
@apeltzer
Copy link
Contributor Author

apeltzer commented Jul 4, 2022

Will provide one in a hot minute

@apeltzer
Copy link
Contributor Author

apeltzer commented Jul 4, 2022

MultiQC/test-data#234

@apeltzer
Copy link
Contributor Author

apeltzer commented Jul 4, 2022

Would be great if we can trigger another pre-release of MultiQC once @ErikDanielsson 's bugfix is in ;-) This still breaks smrnaseq :-(

@ErikDanielsson
Copy link
Collaborator

This should be fixed in #1723 @apeltzer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: module Bug in a MultiQC module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants