Somalier module: the label on y-axis is incorrect

[leonorpalmeira]

Description of bug

In the Somalier module (MultiQC v1.9), the label on the y-axis reads: "Scaled mean depth on X" (which should be around 2 for females and 1 for males given that this is computed by Somalier as "x_depth_mean": 2 * stats[i].x_dp.mean / stats[i].gtdp.mean). However, the value which is plotted is X_mean_depth, see below:

I believe the y-label should be modified.

File that triggers the error

No response

MultiQC Error log

No response

[leonorpalmeira]

From what I see in the current code, the label is still incorrect in the current code base:

[ewels]

oof, so this is a difference between x_depth_mean and x_mean_depth? I can see why that was confused! 😅

Fixing the plot axis is easy, but it might be nicer to have the scaled version which is not sequencing-depth dependent. It should be possible to replicate the formula that you quoted from Somalier above.

With the example data I then get this:

Instead of the original:

I guess that this was the original intention, so let's go with this..

[ewels]

Ok, changes made in 6374939 - please let me know if you spot any issues with the code.

Thanks for the detailed report!

[leonorpalmeira]

The code looks good to me. Thanks for fixing this and for reverting back to what was probably intended!