Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oops! The 'bcftools' MultiQC module broke #1400

Closed
jamigo opened this issue Mar 23, 2021 · 2 comments · Fixed by #1402
Closed

Oops! The 'bcftools' MultiQC module broke #1400

jamigo opened this issue Mar 23, 2021 · 2 comments · Fixed by #1402
Labels
bug: module Bug in a MultiQC module

Comments

@jamigo
Copy link

jamigo commented Mar 23, 2021

Description of bug:
[ERROR ] Oops! The 'bcftools' MultiQC module broke...

MultiQC Error log:

============================================================
Module bcftools raised an exception: Traceback (most recent call last):
  File "/home/user/.local/lib/python3.6/site-packages/multiqc/multiqc.py", line 579, in run
    output = mod()
  File "/home/user/.local/lib/python3.6/site-packages/multiqc/modules/bcftools/bcftools.py", line 39, in __init__
    n["stats"] = self.parse_bcftools_stats()
  File "/home/user/.local/lib/python3.6/site-packages/multiqc/modules/bcftools/stats.py", line 114, in parse_bcftools_stats
    quality = float(s[2].strip())
ValueError: could not convert string to float: '.'
============================================================

File that triggers the error:

content of the file example.vcf.stats.txt

# QUAL	[2]id	[3]Quality	[4]number of SNPs	[5]number of transitions (1st ALT)	[6]number of transversions (1st ALT)	[7]number of indels
QUAL	0	.	76	38	38	19

MultiQC run details (please complete the following):

  • Command used to run MultiQC: /home/user/.local/bin/multiqc -f --no-data-dir -c file.yaml
  • MultiQC Version: MultiQC v1.10
  • Operating System: RHELS 7.5
  • Python Version: Python 3.6
  • Method of MultiQC installation: pip

Additional context

Using bcftools version 1.12 there seems to appear "." values in the [3]Quality column, which are not properly parsed by the bcftools module. I've worked around this issue by changing those "." values to "0.0", but a proper solution should be provided.

@ewels ewels added the bug: module Bug in a MultiQC module label Mar 26, 2021
@ewels
Copy link
Member

ewels commented Mar 26, 2021

Should be a fairly easy PR to catch this exception type and assign the value to 0, if you fancy having a go at it...

@BiscuitCandy
Copy link
Contributor

i have done it
mind checking, someone
PR : solved breakdown bcftools #1402

ewels added a commit to MultiQC/test-data that referenced this issue Mar 29, 2021
@ewels ewels linked a pull request Mar 29, 2021 that will close this issue
vladsavelyev pushed a commit to vladsavelyev/MultiQC_TestData that referenced this issue Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: module Bug in a MultiQC module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants