Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heatmap plotting function is incompatible with toolbox's hide/highlight #1136

Closed
sergpolly opened this issue Mar 29, 2020 · 1 comment
Closed
Labels
bug: core Bug in the main MultiQC code priority: high
Milestone

Comments

@sergpolly
Copy link
Contributor

Description of bug:
built-in heatmap plotting function is incompatible with the MultiQC toolbox, specifically highlight and hide functionality - at times it wouldn't hide anything or wouldn't hide what it is supposed to hide, and highlight seem to "break" heatmap altogether sometimes - please check out screencast for clarification:
heatmap_bug

in this gif I try to hide SRR pattern (nothing gets hidden apart from broken labels), then undo it, then try to hide other pattern - something "bad" happens)) i undo it; then i try to highlight a couple of groups, first nothing happens, then it "breaks", then I try to sort - it just goes crazy at that point .

MultiQC Error log:
does not apply - it is just an interactive javascript issue

File that triggers the error:
This bug is relevant for any report using the built-in heatmap function - I used "FastQC Status Check" for demonstration: MultiQC_TestData/data/modules/fastqc

MultiQC run details (please complete the following):

  • Command used to run MultiQC: multiqc --module fastqc --outdir ./ ./MultiQC_TestData/data/modules/fastqc
  • MultiQC Version: v1.9.dev0 (2e16d7e) [latest from master]
  • Operating System: Ubuntu 18.04.1
  • Python Version: Python 3.7.2
  • Method of MultiQC installation: pip

Additional context:
I think i was able to figure it out, so PR is coming ...

@ewels ewels added the bug: core Bug in the main MultiQC code label Mar 29, 2020
@ewels ewels added this to the MultiQC v1.9 milestone Mar 29, 2020
@ewels
Copy link
Member

ewels commented Apr 29, 2020

Fixed in #1137

@ewels ewels closed this as completed Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: core Bug in the main MultiQC code priority: high
Projects
None yet
Development

No branches or pull requests

2 participants