Workaround for 'OSError: [Errno 18] Invalid cross-device link:' (#806) #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`shutil.copy(..)` leads to `OSError: [Errno 18] Invalid cross-device link` when src and dst are in different filesystems, is reproducible in python 3.6 and 3.8. Workaround is to split it in `shutil.copy()` and `os.remove()`
iromeo
changed the title
ewels
reviewed
Apr 29, 2020
Replaced tmpdir copy behaviour to work properly with directories and contents Fixed up directory naming behaviour for multiqc_plots to work consistently with multiqc_data and report
|
Thanks @iromeo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See detailed description at #806 (comment)
shutil.copy(..)leads toOSError: [Errno 18] Invalid cross-device linkwhen src and dst are in different filesystems, is reproducible in python 3.6 and 3.8. Workaround is to split it inshutil.copy()andos.remove()Many thanks to contributing to MultiQC!
Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things I request on pull requests (PRs).
If this PR is not a new module
CHANGELOG.mdhas been updated