Skip to content
This repository has been archived by the owner on Feb 22, 2020. It is now read-only.

rcedit Failed on Legacy NW.js Version #48

Open
evshiron opened this issue May 26, 2017 · 7 comments
Open

rcedit Failed on Legacy NW.js Version #48

evshiron opened this issue May 26, 2017 · 7 comments
Labels

Comments

@evshiron
Copy link
Owner

No description provided.

@evshiron evshiron added the bug label May 26, 2017
@michapixel
Copy link

i'm on win7

node: 6.9.4
npm: 3.10.10
yarn: 0.24.5

and i think rcedit fails because of user rights or the file (exe) being write protected.

Do you need more info?

@michapixel
Copy link

maybe related:
electron/packager#590

@michapixel
Copy link

updating rcedit didn't change the icon, but at least didn't crash either :-)

@michapixel
Copy link

Grr! Only on first try. so still crashes.

@michapixel
Copy link

rcedit fails to change win-x64 binary, x-86 runs just fine.

@evshiron
Copy link
Owner Author

evshiron commented Jul 6, 2017

I can successfully build the sample project for both Windows x86 and x64 on Windows 10. Can't reproduce.

@michapixel
Copy link

well i cannot, because rcedit fails.
BUT: i boosted the version number in your package.json to 0.9 and this seems to work for x86 and x64 as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants