Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ugly hack to make _filesync work with es6 builds #173

Open
psvensson opened this issue Apr 13, 2016 · 2 comments
Open

Change ugly hack to make _filesync work with es6 builds #173

psvensson opened this issue Apr 13, 2016 · 2 comments

Comments

@psvensson
Copy link
Contributor

Due to reasons, it was nontrivial to just detect file changes in a _filescyn directory anywhere in an es6 project, since basedir got magically remapped to basedir+wwwPath between detection and injection. A quick fix was inflicted on the studio to see if the path ended in /www and then instead check in foo.replace('www','app'). That's no way to behave at a rock'n'roll concert, but time was short.

Revisit this and give it some more love, possible in combination with moving to a proper app registry instead of setting lots of globals when apps change. Plz.

@perttikasanenhitseed
Copy link

If could have the foo.replace('www','app') to use, instead of the fixed directory name 'app', the value of "app-dir" from evothings.json...

...I would not noticed there is anything suspicious going on

@psvensson
Copy link
Contributor Author

Yes, absolutely. This is the way we are thinking as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants