feat(core): Add rollup-plugin-svg #3
Conversation
|
Ah, my bad! fixed |
|
I think rollup-plugin-image might be incompatible with recent versions of Rollup? rollup/rollup-plugin-image#2 is a bit alarming, in any case... Have you confirmed that this works locally? It'd be really swell if there was a test of this functionality... |
|
I updated the PR to use rollup-plugin-svg instead and added an svg import to the integration test to confirm the usage of the loader |
package-lock.json
Outdated
| @@ -8807,6 +8808,14 @@ | |||
| } | |||
| } | |||
| }, | |||
| "rollup-plugin-svg": { | |||
| "version": "1.0.1", | |||
| "resolved": "http://znpm.in.zillow.net:31050/r/rollup-plugin-svg/_attachments/rollup-plugin-svg-1.0.1.tgz", | |||
There was a problem hiding this comment.
sorry, you need to use --registry https://registry.npmjs.org/ when calling npm install, people on the internet dont' have access to Zillow's private network 😅
| 'index.js': File('export default function foo() {};'), | ||
| 'test.svg': File(`test`), | ||
| 'index.js': File( | ||
| `import svgTest from './test.svg'; export default function foo() {};` |
There was a problem hiding this comment.
I think this needs to use the svgTest import, otherwise it gets stripped away. Like, return it from foo() or something. The snapshot should be changing, basically.
evocateur
changed the title
evocateur
force-pushed
the
image-support
branch
from
06e077d
to
1cd206e
Compare
Adds the rollup-plugin-image