Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix: Add deployedBytecode for runtime scripting #690

Merged

Conversation

roninjin10
Copy link
Collaborator

Description

Bytecode and deployedBytecode are different. Bytecode is for deploying deployedBytecode is for running. EVMts vm expects deployedBytecode so we need to add it to the EVMts contract in @evmts/core and also make @evmts/bundler resolve deployedBytecode

Testing

Explain the quality checks that have been done on the code changes

Additional Information

Your ENS/address:

Copy link

vercel bot commented Nov 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
evmts-docs 🛑 Canceled (Inspect) Nov 18, 2023 5:37am

Copy link

changeset-bot bot commented Nov 18, 2023

🦋 Changeset detected

Latest commit: d91e4a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
@evmts/ts-plugin Minor
@evmts/runtime Minor
@evmts/core Minor
@evmts/base Minor
@evmts/solc Minor
@evmts/vm Minor
@evmts/bundler Minor
@evmts/unplugin Minor
@evmts/bun-plugin Minor
@evmts/experimental-solc Minor
@evmts/esbuild-plugin Minor
@evmts/rollup-plugin Minor
@evmts/rspack-plugin Minor
@evmts/vite-plugin Minor
@evmts/webpack-plugin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@roninjin10
Copy link
Collaborator Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@roninjin10 roninjin10 force-pushed the 11-17-fix_Add_deployedBytecode_for_runtime_scripting branch from ba24aac to 711a779 Compare November 18, 2023 05:29
@roninjin10 roninjin10 force-pushed the 11-17-fix_Add_deployedBytecode_for_runtime_scripting branch from 711a779 to d91e4a7 Compare November 18, 2023 05:30
Copy link
Contributor

github-actions bot commented Nov 18, 2023

Coverage Report for @evmts/core (./packages/core)

Status Category Percentage Covered / Total
🟢 Lines 100% / 100% 224 / 224
🟢 Statements 100% / 100% 224 / 224
🟢 Functions 100% / 100% 7 / 7
🟢 Branches 100% / 100% 19 / 19
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/core/src/evmtsContractFactory.ts 100% 100% 100% 100%
packages/core/src/event/eventFactory.ts 100% 100% 100% 100%
packages/core/src/read/readFactory.ts 100% 100% 100% 100%
packages/core/src/write/writeFactory.ts 100% 100% 100% 100%
Generated in workflow #1371

Copy link
Contributor

github-actions bot commented Nov 18, 2023

Coverage Report for @evmts/ethers (./extensions/ethers)

Status Category Percentage Covered / Total
🟢 Lines 100% / 100% 20 / 20
🟢 Statements 100% / 100% 20 / 20
🟢 Functions 100% / 100% 0 / 0
🟢 Branches 100% / 100% 0 / 0
File CoverageNo changed files found.
Generated in workflow #1371

Copy link
Contributor

github-actions bot commented Nov 18, 2023

Coverage Report for @evmts/base (./bundler/base)

Status Category Percentage Covered / Total
🟢 Lines 100% / 100% 285 / 285
🟢 Statements 100% / 100% 285 / 285
🟢 Functions 100% / 100% 13 / 13
🟢 Branches 100% / 100% 57 / 57
File CoverageNo changed files found.
Generated in workflow #1371

Copy link
Contributor

github-actions bot commented Nov 18, 2023

Coverage Report for @evmts/bun-plugin (./bundler/bun)

Status Category Percentage Covered / Total
🟢 Lines 100% / 100% 120 / 120
🟢 Statements 100% / 100% 120 / 120
🟢 Functions 100% / 100% 4 / 4
🟢 Branches 100% / 100% 15 / 15
File CoverageNo changed files found.
Generated in workflow #1371

Copy link
Contributor

github-actions bot commented Nov 18, 2023

Coverage Report for @evmts/esbuild-plugin (./bundler/esbuild)

Status Category Percentage Covered / Total
🟢 Lines 100% / 100% 3 / 3
🟢 Statements 100% / 100% 3 / 3
🟢 Functions 100% / 100% 0 / 0
🟢 Branches 100% / 100% 0 / 0
File CoverageNo changed files found.
Generated in workflow #1371

Copy link
Contributor

github-actions bot commented Nov 18, 2023

Coverage Report for @evmts/ts-plugin (./bundler/ts-plugin)

Status Category Percentage Covered / Total
🟢 Lines 90.56% / 90% 624 / 689
🟢 Statements 90.56% / 90% 624 / 689
🟢 Functions 96.96% / 96% 32 / 33
🟢 Branches 86.08% / 86% 99 / 115
File CoverageNo changed files found.
Generated in workflow #1371

Copy link
Contributor

github-actions bot commented Nov 18, 2023

Coverage Report for @evmts/config (./bundler/config)

Status Category Percentage Covered / Total
🟢 Lines 100% / 100% 704 / 704
🟢 Statements 100% / 100% 704 / 704
🟢 Functions 100% / 100% 33 / 33
🟢 Branches 98.91% / 98% 91 / 92
File CoverageNo changed files found.
Generated in workflow #1371

Copy link
Contributor

github-actions bot commented Nov 18, 2023

Coverage Report for @evmts/schemas (./packages/schemas)

Status Category Percentage Covered / Total
🟢 Lines 100% / 100% 4478 / 4478
🟢 Statements 100% / 100% 4478 / 4478
🟢 Functions 100% / 100% 255 / 255
🟢 Branches 100% / 100% 309 / 309
File CoverageNo changed files found.
Generated in workflow #1371

Copy link
Contributor

github-actions bot commented Nov 18, 2023

Coverage Report for @evmts/blockexplorer (./packages/blockexplorer)

Status Category Percentage Covered / Total
🟢 Lines 100% / 100% 250 / 250
🟢 Statements 100% / 100% 250 / 250
🟢 Functions 100% / 100% 10 / 10
🟢 Branches 100% / 100% 19 / 19
File CoverageNo changed files found.
Generated in workflow #1371

Copy link
Contributor

github-actions bot commented Nov 18, 2023

Coverage Report for @evmts/runtime (./bundler/runtime)

Status Category Percentage Covered / Total
🟢 Lines 100% / 100% 131 / 131
🟢 Statements 100% / 100% 131 / 131
🟢 Functions 100% / 100% 3 / 3
🟢 Branches 90.9% / 90% 20 / 22
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
bundler/runtime/src/generateEvmtsBody.js 100% 100% 100% 100%
bundler/runtime/src/generateEvmtsBodyDts.js 100% 66.66% 100% 100%
Generated in workflow #1371

Copy link
Contributor

github-actions bot commented Nov 18, 2023

Coverage Report for @evmts/solc (./bundler/solc)

Status Category Percentage Covered / Total
🟢 Lines 92.77% / 92% 488 / 526
🟢 Statements 92.77% / 92% 488 / 526
🟢 Functions 100% / 100% 14 / 14
🟢 Branches 72.72% / 72% 48 / 66
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
bundler/solc/src/compiler/compileContracts.js 87.17% 50% 100% 87.17% 126-129, 131-133, 136-148
Generated in workflow #1371

Copy link
Contributor

github-actions bot commented Nov 18, 2023

Coverage Report for @evmts/unplugin (./bundler/unplugin)

Status Category Percentage Covered / Total
🟢 Lines 100% / 100% 111 / 111
🟢 Statements 100% / 100% 111 / 111
🟢 Functions 100% / 100% 5 / 5
🟢 Branches 100% / 100% 17 / 17
File CoverageNo changed files found.
Generated in workflow #1371

Copy link
Contributor

github-actions bot commented Nov 18, 2023

Coverage Report for @evmts/resolutions (./bundler/resolutions)

Status Category Percentage Covered / Total
🟢 Lines 100% / 100% 582 / 582
🟢 Statements 100% / 100% 582 / 582
🟢 Functions 100% / 100% 35 / 35
🟢 Branches 100% / 100% 85 / 85
File CoverageNo changed files found.
Generated in workflow #1371

Copy link
Contributor

github-actions bot commented Nov 18, 2023

Coverage Report for @evmts/effect (./packages/effect)

Status Category Percentage Covered / Total
🟢 Lines 100% / 100% 243 / 243
🟢 Statements 100% / 100% 243 / 243
🟢 Functions 100% / 100% 22 / 22
🟢 Branches 100% / 100% 34 / 34
File CoverageNo changed files found.
Generated in workflow #1371

@roninjin10 roninjin10 merged commit 3af1827 into main Nov 18, 2023
9 of 10 checks passed
@roninjin10 roninjin10 deleted the 11-17-fix_Add_deployedBytecode_for_runtime_scripting branch November 18, 2023 05:35
@github-actions github-actions bot mentioned this pull request Nov 18, 2023
roninjin10 pushed a commit that referenced this pull request Nov 18, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`main` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `main`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @evmts/[email protected]

### Minor Changes

- [#690](#690)
[`3af18276`](3af1827)
Thanks [@roninjin10](https://github.com/roninjin10)! - Added
deployedBytecode to evmts contract instances

### Patch Changes

- Updated dependencies
\[[`3af18276`](3af1827)]:
    -   @evmts/[email protected]
    -   @evmts/[email protected]

## @evmts/[email protected]

### Minor Changes

- [#690](#690)
[`3af18276`](3af1827)
Thanks [@roninjin10](https://github.com/roninjin10)! - Added
deployedBytecode to evmts contract instances

## @evmts/[email protected]

### Minor Changes

- [#690](#690)
[`3af18276`](3af1827)
Thanks [@roninjin10](https://github.com/roninjin10)! - Added
deployedBytecode to evmts contract instances

### Patch Changes

-   Updated dependencies \[]:
    -   @evmts/[email protected]

## @evmts/[email protected]

### Minor Changes

- [#690](#690)
[`3af18276`](3af1827)
Thanks [@roninjin10](https://github.com/roninjin10)! - Added
deployedBytecode to evmts contract instances

### Patch Changes

- Updated dependencies
\[[`3af18276`](3af1827)]:
    -   @evmts/[email protected]

## @evmts/[email protected]

### Minor Changes

- [#690](#690)
[`3af18276`](3af1827)
Thanks [@roninjin10](https://github.com/roninjin10)! - Added
deployedBytecode to evmts contract instances

## @evmts/[email protected]

### Minor Changes

- [#690](#690)
[`3af18276`](3af1827)
Thanks [@roninjin10](https://github.com/roninjin10)! - Added
deployedBytecode to evmts contract instances

## @evmts/[email protected]

### Patch Changes

- Updated dependencies
\[[`3af18276`](3af1827)]:
    -   @evmts/[email protected]
    -   @evmts/[email protected]
    -   @evmts/[email protected]
    -   @evmts/[email protected]
    -   @evmts/[email protected]
    -   @evmts/[email protected]
    -   @evmts/[email protected]

## @evmts/[email protected]

### Patch Changes

- Updated dependencies
\[[`3af18276`](3af1827)]:
    -   @evmts/[email protected]

## @evmts/[email protected]

### Patch Changes

-   Updated dependencies \[]:
    -   @evmts/[email protected]

## @evmts/[email protected]

### Patch Changes

-   Updated dependencies \[]:
    -   @evmts/[email protected]

## @evmts/[email protected]

### Patch Changes

-   Updated dependencies \[]:
    -   @evmts/[email protected]

## @evmts/[email protected]

### Patch Changes

- Updated dependencies
\[[`3af18276`](3af1827)]:
    -   @evmts/[email protected]
    -   @evmts/[email protected]

## @evmts/[email protected]

### Patch Changes

-   Updated dependencies \[]:
    -   @evmts/[email protected]

## @evmts/[email protected]

### Patch Changes

-   Updated dependencies \[]:
    -   @evmts/[email protected]

## @evmts/[email protected]

### Patch Changes

- Updated dependencies
\[[`3af18276`](3af1827)]:
    -   @evmts/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant