-
Notifications
You must be signed in to change notification settings - Fork 569
Problem: eth_gasPrice/eth_maxPriorityFeePerGas shouldn't return a price bigger than needed #816
Comments
This fix would fix non-EIP 1559 tx when baseFee < minimal-gas-price But there is another issue with our current design, which is that if baseFee < minimal-gas-price, then EIP1559 tx that don't set the tip parameter will get rejected. Would it be better to return Another suggestion is the one proposed in the telegram channel, ie not check the |
The problem is |
Yes.. So I guess the better option is not check the minimal-gas-price for ethereum transaction but the basefee instead |
fixed by #916 |
Proposal: eth_gasPrice should count in the minimal-gas-prices
Current behavior:
Currently
eth_gasPrice
returnsbase_fee + min_gas_price
, but in reality, the ante handler check eip-1559 fee and minimal-gas-prices separately, so it should returnmax(minimal-gas-price, base-fee)
.And
eth_maxPriorityFeePerGas
should returneth_gasPrice - base-fee
.Desired behavior: return
max(minimal-gas-price, base-fee)
Use case: To keep the returned gas price reasonable.
The text was updated successfully, but these errors were encountered: