Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Include tx and tm service in cosmos api server #172

Closed
yihuang opened this issue Jun 23, 2021 · 4 comments · Fixed by #478
Closed

Include tx and tm service in cosmos api server #172

yihuang opened this issue Jun 23, 2021 · 4 comments · Fixed by #478

Comments

@yihuang
Copy link
Contributor

yihuang commented Jun 23, 2021

Proposal: Include tx and tm service in cosmos api server

Current behavior: Missing some apis in api server

Desired behavior:

  • register tx service and tendermint service to api server
  • update swagger doc

Use case: better UX

I tried it here: yihuang@0daebad, but get error in /block/latest api:

Unregistered interface types.Evidence
@fedekunze
Copy link
Contributor

can you provide more info about the actionable items?

@fedekunze fedekunze added the Status: Needs More Info This bug can't be addressed until more information is provided by the reporter. label Jun 23, 2021
@yihuang
Copy link
Contributor Author

yihuang commented Jun 23, 2021 •
edited
Loading

can you provide more info about the actionable items?

  • add these lines of code when start node.
  • update proto files and swagger doc to latest cosmos-sdk.

Actually I've done above two in my branch, it's just I got the issue with some api.

@fedekunze fedekunze removed the Status: Needs More Info This bug can't be addressed until more information is provided by the reporter. label Jun 23, 2021
@khoslaventures khoslaventures added this to the Milestone 1: Developer Usability and Testing milestone Jun 23, 2021
@yihuang yihuang assigned yihuang and unassigned yihuang Jul 8, 2021
@yihuang yihuang mentioned this issue Jul 22, 2021
Closed
@github-actions
Copy link

This issue is stale because it has been open 45 days with no activity. Remove Status: Stale label or comment or this will be closed in 7 days.

@fedekunze
Copy link
Contributor

@yihuang I still get the Unregistered interface types.Evidence error but it seems that your changes are already included

@fedekunze fedekunze mentioned this issue Aug 23, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

codec: register Evidence evmos/ethermint
3 participants
@yihuang @khoslaventures @fedekunze