Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a ~Validation~ Result crock #6

Closed
evilsoft opened this issue Nov 20, 2016 · 5 comments
Closed

Add a ~Validation~ Result crock #6

evilsoft opened this issue Nov 20, 2016 · 5 comments

Comments

@evilsoft
Copy link
Owner

evilsoft commented Nov 20, 2016 •
edited
Loading

We should make a specialized Validation crock for accumulating Validations.
@evilsoft evilsoft changed the title Add a Validation crocks Add a Validation crock Nov 20, 2016
@evilsoft evilsoft assigned evilsoft and unassigned evilsoft Nov 20, 2016
@evilsoft evilsoft added this to the v0.2.0 milestone Dec 12, 2016
@evilsoft evilsoft modified the milestones: v0.2.0, v0.2.1 Jan 18, 2017
@evilsoft
Copy link
Owner Author

Gonna punt on this for now, want to put more focus on things like Natural Transformation on the essentials. This can come later.

@evilsoft evilsoft removed this from the v0.2.1 milestone Jan 28, 2017
@evilsoft
Copy link
Owner Author

evilsoft commented Feb 4, 2017

It is time.

@evilsoft evilsoft reopened this Feb 4, 2017
@evilsoft evilsoft added this to the 0.2.4 milestone Feb 11, 2017
@evilsoft evilsoft removed this from the 0.2.4 milestone Feb 19, 2017
@evilsoft
Copy link
Owner Author

So this is no longer going to be called Validation going to make this into a Result type and keep the accumulation of Err on the ap like expected in a Validation.
This means that tryCatch should be updated to return a Result instead of the vanilla Either

@evilsoft evilsoft changed the title Add a Validation crock Add a ~Validation~ Result crock Feb 26, 2017
@evilsoft evilsoft mentioned this issue Mar 6, 2017
Merged
@evilsoft
Copy link
Owner Author

evilsoft commented Mar 6, 2017

Added PR#100 to address this.

@evilsoft
Copy link
Owner Author

evilsoft commented Mar 7, 2017

Merged PR#100. Will go out next release.
Closing

@evilsoft evilsoft closed this as completed Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@evilsoft