Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would love to contribute, have few queries #15

Closed
subhashdasyam opened this issue Jul 5, 2024 · 4 comments
Closed

Would love to contribute, have few queries #15

subhashdasyam opened this issue Jul 5, 2024 · 4 comments

Comments

@subhashdasyam
Copy link
Contributor

subhashdasyam commented Jul 5, 2024

I would like to take the following #TODO

https://github.com/evilsocket/nerve/blob/main/src/agent/namespaces/http/mod.rs#L185

I need more information on what response type and how do you want this to be handled :)

like json, text/html, text/plain ?

@evilsocket @eltociear @5ibyl

@evilsocket
Copy link
Owner

evilsocket commented Jul 5, 2024

hey @subhashdasyam that's awesome! thank you so much

the main idea is pretty simple:

  • everything text/* and application/* gets added to the response as it is
  • anything else (non textual documents) should NOT be added to the response since the model can't possibly understand it anyway (for now, in the future images could be sent to multimodal LLMs), so the body can be replaced with something like "BINARY DATA" or whatever

thoughts?

@subhashdasyam
Copy link
Contributor Author

Make sense and I agree :-) will submit PR for this soon

@subhashdasyam
Copy link
Contributor Author

@evilsocket please verify the PR :-) if that's what you have in your mind

@evilsocket
Copy link
Owner

merged! thanks @subhashdasyam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants