Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install of v1.8.3+ breaks when git version is < 2.31.0 #876

Open
mwilsoncoding opened this issue Nov 18, 2024 · 3 comments
Open

Install of v1.8.3+ breaks when git version is < 2.31.0 #876

mwilsoncoding opened this issue Nov 18, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@mwilsoncoding
Copy link

mwilsoncoding commented Nov 18, 2024

🔧 Summary

Today, when installing 1.8.3 or 1.8.4 on a fresh build of a linux container (elixir:1.14.2 in my case <- debian base), I could not boot into my environment due to the following error:
image

This issue seems to be related.

This other issue also seems related.

After testing, I discovered this is only broken as of v1.8.3

Lefthook version

1.8.3 and 1.8.4

Steps to reproduce

Boot into any devcontainer configured to pull latest lefthook and try to lefthook install

Expected results

Install completes successfully.

Actual results

Error creating directory that already exists.

Possible Solution

I'll have to dig a bit deeper before I have relevant feedback, but answers may lie in this PR that closed the related first issue mentioned above.

For the time being, I'm pinning my lefthook usage at 1.8.2 until this is resolved.

Logs / Screenshots

image

@mwilsoncoding mwilsoncoding added the bug Something isn't working label Nov 18, 2024
@mwilsoncoding mwilsoncoding changed the title Install on debian is broken as of 1.8.3 Install on debian devcontainer is broken as of 1.8.3 Nov 18, 2024
@mwilsoncoding mwilsoncoding changed the title Install on debian devcontainer is broken as of 1.8.3 Install on debian container is broken as of 1.8.3 Nov 18, 2024
@mrexox
Copy link
Member

mrexox commented Nov 19, 2024

Looks like the cause is the recent change - #873, and it looks like old git does not support --path-format=absolute. On elixir:1.14.2 the git version is 2.30.2 when the --path-format firstly appeared in 2.31.0.

Quick fix is to continue using version 1.8.2. I will try to fix this issue for old git versions, but this is probably not a quick fix.

@mwilsoncoding
Copy link
Author

That would make sense. Thanks much for taking a deeper look. I'm also looking into updating the base image used in my development environment.

@mwilsoncoding mwilsoncoding changed the title Install on debian container is broken as of 1.8.3 Install of v1.8.3+ breaks when git version is < 2.31.0 Nov 19, 2024
@mwilsoncoding
Copy link
Author

I updated the title to more accurately reflect the nature of the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants